<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Commit with the change from PHPUnit: <a class="commit-link" data-hovercard-type="c

Sounds like we hardcode the quoted option: <div class="Box Box--condensed my-2

Fixed in <a class="issue-link js-issue-link" data-error-text="Failed to load title" da

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Incorrect --filter with PHPUnit 10 about infection HOT 10 CLOSED

dkarlovi commented on June 5, 2024

Incorrect --filter with PHPUnit 10

from infection.

Comments (10)

dkarlovi commented on June 5, 2024 2

@sanmai I can confirm it was fixed! 🍾

from infection.

dkarlovi commented on June 5, 2024 1

Ah, nevermind, you're already doing that. It seems the bugfix will not be terrible, just need to adjust the behaviour to match what PHPUnit is doing

numeric #X
else "X"

from infection.

dkarlovi commented on June 5, 2024

One thing that might be a nice addition to prevent regressions: Infection knows how many tests it expects to run with the --filter, if it runs fewer, the filter is invalid. Maybe it could be added to the test suite?

from infection.

sanmai commented on June 5, 2024

Commit with the change from PHPUnit:
sebastianbergmann/phpunit@c8ec808

from infection.

sanmai commented on June 5, 2024

Sounds like we hardcode the quoted option:

infection/src/TestFramework/PhpUnit/CommandLine/ArgumentsAndOptionsBuilder.php

Lines 138 to 143 in 5d7a36f

 if (count($methodNameParts) > 1) { 

 $methodName = $methodNameParts[0]; 

 $dataProviderKey = $methodNameParts[1]; 

 $methodNameWithDataProviderResult = sprintf('%s with data set "%s"', $methodName, $dataProviderKey); 

 }

Where PHPUnit expects either quoted or has-prefixed variant.

from infection.

dkarlovi commented on June 5, 2024

The annoying part is this is now versioned, PHPUnit 10+ expects the new behaviour. :| You'd need to detect which version it is and change it.

from infection.

maks-rafalko commented on June 5, 2024

Thanks for the bug report and details!

Personally, I won't be able to look into this until the weekend. So feel free to help/fix it if you need it quicker.

from infection.

sidz commented on June 5, 2024

Fixed in #1900

from infection.

maks-rafalko commented on June 5, 2024

Released https://github.com/infection/infection/releases/tag/0.27.9

from infection.

sanmai commented on June 5, 2024

@dkarlovi Can you confirm we fixed it?

from infection.

Recommend Projects

Incorrect --filter with PHPUnit 10 about infection HOT 10 CLOSED

Comments (10)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	if (count($methodNameParts) > 1) {
	$methodName = $methodNameParts[0];
	$dataProviderKey = $methodNameParts[1];

	$methodNameWithDataProviderResult = sprintf('%s with data set "%s"', $methodName, $dataProviderKey);
	}