VÖBB (Berlin) uses a different auth flow than most/all other libraries and currently is not supported.

As I don't have an account with VÖBB, I can't test if my changes work and maybe will also need some help during development/reverse engineering their auth flow.

I try to set-up the software for my kids and during the login procedure the plug-in stops with an unknown error.

During the (web) login procedure there is an additional screen which asks to confirm the data transfer of the age. I suspect this could be the issue:

In v1.0.3 it is not possible to play single episodes (only movies work).

From the exception in the log it looks like the result of requests.get(f'https://api.tenant.frontend.vod.filmwerte.de/v11/{lm4utils.getSetting("tenant")}/movies/{videoId}/uri',headers=headers) is not proper JSON

Or maybe the movies part of the URL is wrong

Selecting Season 1 of "Benjamin Blümchen" for example shows a list of 10 episodes without a title

When you have an entry on your watchlist that is no longer available, playback fails with a generic error message that says to check the log for details.

Ways to improve

• don't show watchlist entries that are no longer available
• OR show some meaningful message when trying to play entries that are no longer available

When the addon is started for the first time it would be nice if the user could be taken to the login procedure right away.

When I was trying to login to filmfriend using my credentials for the "Universität Mannheim", I got the following error:

error <general>: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <class 'KeyError'>
Error Contents: 'location'
Traceback (most recent call last):
  File "/Users/mechnich/Library/Application Support/Kodi/addons/plugin.video.filmfriend.de/default.py", line 52, in <module>
    login.pick()
  File "/Users/mechnich/Library/Application Support/Kodi/addons/plugin.video.filmfriend.de/resources/lib/login.py", line 175, in pick
    firstRedirectUrl = response.headers['Location']
                       ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
File "/Users/mechnich/Library/Application Support/Kodi/addons/script.module.requests/lib/requests/structures.py", line 52, in __getitem__
  return self._store[key.lower()][1]
         ~~~~~~~~~~~^^^^^^^^^^^^^
KeyError: 'location'
-->End of Python script error report<--

After looking at the code it seems that login via Shibboleth is not supported (and probably also not that easy to implement). However, my university also supports login via IP if the host uses the university's network.

Unfortunately, at least in this case, sign in via IP is listed as a delegated login method and external takes precedence.

It would already be helpful if it was possible to explicitly select one of the login methods during login.

The following is the provider info for the "Universität Mannheim" (tenant id bffebeed-05f8-40bf-937d-aeada3e8a2b7):

{
  'local': None,
  'delegated': [
    {
      'provider': 'ff4da517-dd2a-4c50-936d-f38d155cc242',
      'displayName': 'Sign in via IP',
      'providerKind': 'Ip',
      'information': 'Sign in via IP',
      'userNameKind': None
    }
  ],
  'external': [
    {
      'provider': '15647c4b-2f6e-45c1-9643-c3c8e9ab17d1',
      'displayName': 'Sign in via Shibboleth',
      'providerKind': 'Shibboleth'
    }
  ]
}

When selecting the watchlist without having selected a library (and therefore no valid login) the UI just shows the generic error message that tells to check the log.

Internally a call to https://api.tenant.frontend.vod.filmwerte.de/v11//watchlist fails with 404 Not Found that is not explicitly handled.

The library selection for login only contains German libraries at the moment.

In order to support the libraries from Austria and Switzerland a country selector needs to be added as the first step of the login procedure.
Hopefully the rest stays the same.

Not yet sure when exactly this is happening, but after a while, HTTP calls run into a 401 Unauthorized error.
In the UI this results in a generic error message that says to check the log file.

Ideally the authentication would get refreshed automatically.
If that's not possible, at the least the message should be changed to tell users to log in again (which fixes the problem).

I was delighted when I read your fork also supports Austrian libraries. I was able to login, but can not seem to play any video. I'm not sure if the issue lies in the plugin itself or if there is a different issue. Is it possible to turn on debuggin to get more information?

I've tried 1.0.11 and 1.0.12-beta-1

Widevine CDM is version 4.10.2710.0

Here's the log-output, which doesn't help much I guess:

2024-07-07 11:08:06.820 T:459408    info <general>: VideoPlayer::OpenFile: plugin://plugin.video.filmfriend.de/?mode=playVideo&video=e0c1d49d-96a7-44e3-97b3-dc65555a711c
2024-07-07 11:08:06.821 T:10375    info <general>: Creating InputStream
2024-07-07 11:08:06.821 T:10375   error <general>: IAddonInstanceHandler::CreateInstance: inputstream.adaptive returned bad status "Permanent failure" during instance creation
2024-07-07 11:08:06.821 T:10375   error <general>: CVideoPlayer::OpenInputStream - error opening [plugin://plugin.video.filmfriend.de/?mode=playVideo&video=e0c1d49d-96a7-44e3-97b3-dc65555a711c]
2024-07-07 11:08:06.821 T:10375    info <general>: CVideoPlayer::OnExit()
2024-07-07 11:08:06.952 T:459408    info <general>: CVideoPlayer::CloseFile()
2024-07-07 11:08:06.952 T:459408    info <general>: VideoPlayer: waiting for threads to exit
2024-07-07 11:08:06.952 T:459408    info <general>: VideoPlayer: finished waiting
2024-07-07 11:08:11.824 T:459432    info <general>: JSONRPC Server: Disconnection detected
2024-07-07 11:08:11.966 T:459432    info <general>: JSONRPC Server: New connection added
2024-07-07 11:08:37.121 T:459432    info <general>: JSONRPC Server: Disconnection detected

While watching a series I noticed that the episodes were not sorted in the proper order. Also the episode title didn't contain an episode number so I had to look up the right order elsewhere.

The default ordering should be by episode number.

Depending on the version of the Python "cryptography" module (used by pyjwt) loading the plugin fails with the following error message in the log

PyO3 modules may only be initialized once per interpreter process

A workaround is to not use pyjwt for checking access token expiry by editing jsonparser.py

• comment out import pyjwt as jwt
• add a return statement as first line in method _checkTokenExpired()

Thanks for forking and maintaining the code! It would be nice if you could created releases to make it easier to install the packages in Kodi.