init-hf / gr-corrsounder Goto Github PK

• For pycorrsounder routines
• For gr-corrsounder blocks

Hello,

I recently read your paper "A Software-Defined Channel Sounder for Industrial
Environments with Fast Time Variance" and I thought I should check out your gr-corrsounder module.

I installed the module successfully, but there seems to be some DSP block missing. As mentioned in the article the DSP blocks sequence source, sequence gate, sequence corre-
lation, error correction, channel characterization, and the meta information can be found in gr-corrsounder, however only sequence source, sequence correlation and error correction blocks were installed. Also the mentioned executable flow-graphs Channel Sounding, Sequence Stimulation, Sequence Correlation and Calibration are missing. Kindly assist me in these issues.

Thank you.

Reverts #3

• Check MLS sequence generation and its implementation:

  • Sequence Source Block
  • Sequence Correlator Block

• Activate MLS sequence generation usage in corrsounder architecture:

  • Sequence Source Block
  • Sequence Correlator Block

The CMake community wiki has moved to Kitware GitLab Instance.

change link to: https://gitlab.kitware.com/cmake/community/wikis/FAQ#can-i-do-make-uninstall-with-cmake

The function def sequence_frank_zadoff_chu in corrsounder.py should contain a quick test, if the variables N_seq and q are coprime to each other.
This will prevent users from accidentally choosing wrong sequence parameters according to the theory.

Add CMake uninstall instructions to README.md:

# Uninstall/Remove instructions

1.  Navigate to gr-corrsounder/build

2.  Optional: Change from which prefix *gr-corrsounder* shall be uninstalled - `source ~/corrsounder_prefix/setup_env.sh`

3.  Uninstall *gr-corrsounder* - `sudo make uninstall`

4. Delete the gr-corrsounder folder

As implemented in #7, trying to generate an FZC sequence with two non-coprime parameters sequence_length and q will return -1 to indicate an error.

The function def sequence_frank_zadoff_chu in corrsounder.py needs to generate a verbose error message telling the user that they tried to use two non-coprime numbers.

CGRAN 1652

The test suite test_suite.py contains a wrong FZC sequence.
According to the theory, an FZC sequence needs to be generated with sequence length N_seq and generation parameter q coprime to each other. While q = 1 is coprime to N_seq = 10( see Wikipedia ). it is not a nice example to use in the test suite.

Also, the sequence exp = ... needs to be checked.
If the sequence was generated using the faulty corrsounder.py, the sequence was generated with the wrong formula.

def test_sequence_frank_zadoff_chu(self):
        ''' Check exemplary FZC sequence '''
        N_seq = 10
        q = 1
        res = corrsounder.sequence_frank_zadoff_chu(N_seq, q)
        exp = [(-1+1.2246467991473533e-15j), (1-1.2246467991473533e-15j), (-1+1.2246467991473533e-15j), (1-1.2246467991473533e-15j), (-1+1.2246467991473533e-15j), (1-1.2246467991473533e-15j), (-1+1.2246467991473533e-15j), (1-1.2246467991473533e-15j), (-1+1.2246467991473533e-15j), (1-1.2246467991473533e-15j)]
        np.testing.assert_almost_equal(res, exp)

The GNU Radio blocks Sequence Correlator and Sequence Source should contain a note, that the parameters Sequence Length and FZC Parameter q need to be coprime.

• GNU Radio 3.10 OOT Module Porting Guide