Name chain does not work in case last composition name matches about nexrender HOT 11 CLOSED

I will send some final resolution about this during the day.

from nexrender.

Proposed solution:

    function isNestedComp(comp, name, parentChain) {
        if (
          name &&
          comp.name === name &&
          parentChain &&
          parentChain.length > 0 &&
          comp.usedIn.length > 0
        ) {
          for (var i = 0; i < comp.usedIn.length; i++) {
            if (
              comp.usedIn[i] instanceof CompItem &&
              comp.usedIn[i].name === parentChain[parentChain.length - 1]
            ) {
              var parentComp = comp.usedIn[i];
              if (parentChain.length === 1) {
                return true;
              } else {
                var chainCopy = [...parentChain];
                var isNested = isNestedComp(
                  parentComp,
                  chainCopy.pop(),
                  chainCopy
                );
                if (isNested) {
                  return true;
                }
              }
            }
          }
        }
        return false;
    }

from nexrender.

Have you had a chance to test the proposed solution @ivansenic ?
I might be wrong, but I feel like the [...] operator would not work in the older jsx scripting environment of AE

from nexrender.

Did not test it yet, will try tomorrow. Would .slice(..) be better alternative?

from nexrender.

Actually yeah, there potentially could work:

var chainCopy = parentChain.slice()
// or
var chainCopy = [].concat(parentChain)

from nexrender.

Will test this today with slice() and report back once I have resulsts..

from nexrender.

@inlife My solution does not work.. It still matches the first parent found so yea does now work.. I'll continue exploring the options..

from nexrender.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from nexrender.

Will be looking forward to that!

from nexrender.

I my comment I said that the fix is not working, but that's not really true. The fix proposed is definitely a good one, however, I would like to explain in what situations it helps and why I said it's not working in the test we did.

There are two situations to distinguish. When a same composition is used in two different parents, and when two completely different compositions have a same name.

Situation 1: Same comp in different parents

In this case we have a same composition included in two different parents. So we have following situation (made up IDs in brackets):

• First (1) -> Target comp (3)
• Second (2) -> Target comp (3)

Now without the fix above, following happens:

• If you target a layer First->Target comp, it will work and layer would be updated. Because it's the same comp, it will be updated in that Target comp which influences both First (1) and Second (2).
• If you target a layer Second->Target comp, it will not work and nothing will be updated (proposed fix solves this issue).

Now important is to understand that in this situation there is no way to update the layer only in one concrete path. As composition is contained in two parents, any matched path would influence the comp and thus both parents. This is the reason I said fix is not working at the first place, as it's actually impossible to achieve once you have same comp in different parents.

Situation 2: Different comps with same name

In this case we have different compositions included in two different parents. So we have following situation (made up IDs in brackets):

• First (1) -> Target comp (3)
• Second (2) -> Target comp (4)

Now without the fix above, following happens:

• If you target a layer First->Target comp, it will work and layer would be updated. Because it's the different target comp, it will be updated on in the composition contained in the First (1).
• If you target a layer Second->Target comp, it will not work and nothing will be updated (proposed fix solves this issue).

Conclusion

Fix is improving the path based selection for sure. It's deployed in our production for over a month now and we saw no other issues or any backward incompatibility.

from nexrender.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from nexrender.