innoteq / devpi-slack Goto Github PK

Error case does not provide info suitable for debug, because logging is broken.

Environment:

• python==3.6.1
• devpi-server==4.3.0
• devpi-slack==0.1.2

Error:

Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/devpi_slack/main.py", line 50, in devpiserver_on_upload_sync
    log.debug(r.content)
  File "/usr/lib/python3.6/site-packages/devpi_server/log.py", line 50, in debug
    self._logout.debug(self._prefix + msg, *args)
TypeError: must be str, not bytes

I'm using these versions of devpi and devpi-slack:

devpi-server-6.3.1
devpi-slack-0.1.3
devpi-web-4.0.8

Does this plugin still work with the latest version of devpi? I can see a log message that the plugin is found and loaded, but no message is sent to Slack on upload.

I'm assuming that the plugin exits on this line, because no message is logged that a message was sent to Slack or that any error was received. This means that somehow the index config was not read correctly, because there is a slack_hook variable present.

Hi,

When we do uploads we end up getting duplicate messages posted to Slack (eg. "Uploaded mypackage==3.0.dev1234 to https://devpi.example.com"). My initial guess is that maybe the source tgz and the wheel components are both treated as uploads independently, so we get the message twice?

Could devpi_slack suppress dupe messages? eg. compare the latest message to the previous one sent and skip if they match. Wouldn't be perfect in edge cases but is a pretty simple 99% solution.

The current version on Pypi is out of date and does not work with devpi-server >= 4.

You should release a new version on Pypi.