inorton / edmchits Goto Github PK

If I jump to a system the plugin works fine, as well as if I simply type !location in chat, however if I try (for example) !location Ceos or !location Alioth the plugin doesn't ever display anything in response.

Also would you consider aliasing !location as !loc?

Regression: When the game closes or crashes the overlay should auto exit but does not

I noticed during a recent CG that HITS was reporting zero activity in the CG location which struck me as odd, so I was wondering whether or not information is being submitted to the server anymore.

One report so far where user input not getting to ED caused them to have to force-quit it

I discovered HITS earlier today whilst cantering through EDMC's plugins page, and I'm surprised that I missed it before; I really like the way it looks, and indeed how blends into the style of Elite itself. Attempting to run it under Linux (after running the .msi and copying out the result), however, results in the following error:

2021-06-08 13:59:59.388 - INFO - 62386:140004381419328:62386 <plugins>.edmcoverlay._edmcoverlay._Overlay.__init__:37: edmcoverlay2: hiiiiiii
2021-06-08 13:59:59.388 - DEBUG - 62386:140004381419328:62386 <plugins>.edmcoverlay._edmcoverlay._Overlay.__init__:42: edmcoverlay2: init
2021-06-08 13:59:59.388 - INFO - 62386:140004256904768:62401 <plugins>.edmcoverlay._edmcoverlay._Overlay.__server:95: edmcoverlay2: server running
2021-06-08 13:59:59.388 - DEBUG - 62386:140004381419328:62386 <plugins>.edmcoverlay._edmcoverlay.edmcoverlay._edmcoverlay:210: edmcoverlay2: overlay class instantiated
2021-06-08 13:59:59.388 - DEBUG - 62386:140004381419328:62386 <plugins>.edmcoverlay.load.plugin_edmcoverlay:21: edmcoverlay2: got lib: <module 'edmcoverlay' from '/home/bradleyr/.local/share/EDMarketConnector/plugins/edmcoverlay/__init__.py'>
2021-06-08 13:59:59.389 - DEBUG - 62386:140004381419328:62386 <plugins>.edmcoverlay.load.plugin_edmcoverlay:23: edmcoverlay2: got internal lib: <module 'edmcoverlay._edmcoverlay' from '/home/bradleyr/.local/share/EDMarketConnector/plugins/edmcoverlay/_edmcoverlay.py'>
2021-06-08 13:59:59.389 - INFO - 62386:140004381419328:62386 <plugins>.edmcoverlay.load.plugin_start3:66: edmcoverlay2: plugin start!
2021-06-08 13:59:59.389 - INFO - 62386:140004381419328:62386 plug.Plugin.__init__:46: loading plugin "cargo-manifest-2_1_0" from "/home/bradleyr/.local/share/EDMarketConnector/plugins/cargo-manifest-2.1.0/load.py"
2021-06-08 13:59:59.794 - INFO - 62386:140004381419328:62386 plug.Plugin.__init__:46: loading plugin "FuelStatus" from "/home/bradleyr/.local/share/EDMarketConnector/plugins/FuelStatus/load.py"
2021-06-08 13:59:59.794 - DEBUG - 62386:140004381419328:62386 <plugins>.FuelStatus.load.plugin_start3:22: fuelstatus plugin loaded
2021-06-08 13:59:59.794 - INFO - 62386:140004381419328:62386 plug.Plugin.__init__:46: loading plugin "HITS" from "/home/bradleyr/.local/share/EDMarketConnector/plugins/HITS/load.py"
2021-06-08 13:59:59.796 - ERROR - 62386:140004381419328:62386 plug.Plugin.__init__:61: : Failed for Plugin "HITS"
Traceback (most recent call last):
  File "/home/bradleyr/Games (NVME)/Utilities/Elite Dangerous/EDMarketConnector/plug.py", line 52, in __init__
    newname = module.plugin_start3(os.path.dirname(loadfile))
  File "/home/bradleyr/.local/share/EDMarketConnector/plugins/HITS/load.py", line 43, in plugin_start3
    plugin_start()
  File "/home/bradleyr/.local/share/EDMarketConnector/plugins/HITS/load.py", line 53, in plugin_start
    _overlay = edmcoverlay.Overlay()
AttributeError: 'NoneType' object has no attribute 'Overlay'
2021-06-08 13:59:59.797 - ERROR - 62386:140004381419328:62386 plug.load_plugins:158: Failure loading found Plugin "HITS"
Traceback (most recent call last):
  File "/home/bradleyr/Games (NVME)/Utilities/Elite Dangerous/EDMarketConnector/plug.py", line 156, in load_plugins
    found.append(Plugin(name, os.path.join(config.plugin_dir_path, name, 'load.py'), plugin_logger))
  File "/home/bradleyr/Games (NVME)/Utilities/Elite Dangerous/EDMarketConnector/plug.py", line 52, in __init__
    newname = module.plugin_start3(os.path.dirname(loadfile))
  File "/home/bradleyr/.local/share/EDMarketConnector/plugins/HITS/load.py", line 43, in plugin_start3
    plugin_start()
  File "/home/bradleyr/.local/share/EDMarketConnector/plugins/HITS/load.py", line 53, in plugin_start
    _overlay = edmcoverlay.Overlay()
AttributeError: 'NoneType' object has no attribute 'Overlay'

I use EDMCOverlay2 for overlay functionality on Linux so can understand that HITS would be unlikely to work out of the box, but presuming it uses much of the same resources as it's Windows equivalent (EDMCOverlay2 'aims to be 100% compatible with EDMC Overlay'), is there anything that can be done to get it working?

Feature request (Asking humbly and politely)
I run EDMC on a separate computer, giving it access to necessary journal/log files over the network.
In fact, I run almost all my 3rd party apps on a second computer.

Any chance for added functionality allowing HITS to run on a second computer together with EDMC.
Would require a warning window rather than an overlay to display HITS messages.

(If this somehow is already possible, I have missed it)

I'd like the ability to message !stats to another commander and then EDMCHits would respond with the number of players that the commander to whom the message was sent has been logged as killing in HITS.

I'm happy to contribute the changes to the load.py file, but it looks like it would require a new response be supported by the edmc.edhits.space:8080 in order to enable something like this to work.

Would you be open to this idea?

• Tag ships when you encounter them by sending a tracking worm over comms.
  Possibly make use of a combination of commander history data and a chat command "!tag"
• Auto-report ships that attack you

Hi, I'm the new maintainer for EDMC itself. I intend to move releases over to Python 3.7 sometime in the next 1-2 weeks. As such your users who upgrade EDMC will see your plugin stop working at that point.

I'm first looking at adding some code to the upcoming final Python 2.7-based release of EDMC to detect plugins that don't yet have a plugin_start3() method and alert the user. So your users will start getting that alert when I release (what is planned to be) 3.4.6.0 / 3.46.

If you check EDMC Available Plugins I can tell you that at least 'Habitable Zone' has already updated, so you could use it as a reference. Several others have as well, including dual Python 2.7/3.7 support.

Github has a tags feature that I've found to be quite useful for finding repos related to Elite Dangerous. I noticed that this one might benefit from adding the elite-dangerous tag. Github calls them topics and says: To associate your repository with the elite-dangerous topic, visit your repo's landing page and select "manage topics." I'm very glad I found this fun project, and hope this would help others to do so as well.

It appears to be that whenever I input the !location+the name of any given system it no longer shows me on the EDMC overlay the given xyz system status of ships passed safely and destroyed alike. Am I missing something? Thanks for your feedback :)

Greetings,

As I see there is still fairly recent activity on this hopefully asking in here might save me a lot of time digging through the code to find that for which I'm seeking.

I play E:D on a triple 1920 x 1080 setup. (running as a single 5760 x 1080 monitor) Hence, the text displayed from the overlay places it on my left side. I would like it centered as it should be.

I'm sure I just need to add 1920 to somewhere in the setup file, but I'm not finding it right away. I'm not a coder, even if I've done a fair bit of scripting in my day.

Even when the game is not on top, overlay still renders.

Server seems to be vacant of information

I see when I scan a target I see this orange box with a few lines in it I assume its broken or is it supposed to just show that?

When we are interdicted, upload the details to the server

We only support windowed and borderless mode at current.

Fullscreen mode will require dll injection.. is rather tricky

I've extracted HITS and EDMCOverlay-master into EDMC Plugins directory but I don't get anything when jumping between systems.

They are both shown as enabled Plugins in the settings menu for EDMC.

Server address is: edmc.edhits.space:8080

The game is running on the Primary monitor of a 3 monitor setup and is running in Borderless mode.

What am I doing wrong?

Its truly annoying that I've downloaded this plugin and get no response whatsoever when checking the location of each system,

it would be nice to be able to use the EDMC window as data/output container like EDR does, this would enable a safe option to use for VR or Fullscreen users

I had HITS working for a day but now I have this exception with EDMCOverlay.exe:

2018-01-06T23:22:23 OverlayRenderer: Loading fonts..
2018-01-06T23:22:23 OverlayJsonServer: JSON server thread startup
2018-01-06T23:22:23 EDMCOverlay: unhandled exception!!: Name:EDMCOverlay.exe
There are no context policies.
 System.UnhandledExceptionEventArgs
2018-01-06T23:22:23 EDMCOverlay:    at System.Diagnostics.ProcessManager.OpenProcess(Int32 processId, Int32 access, Boolean throwIfExited)
   at System.Diagnostics.Process.GetProcessHandle(Int32 access, Boolean throwIfExited)
   at System.Diagnostics.Process.get_HasExited()
   at EDMCOverlay.OverlayRenderer.StartUpdate()
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()

Possibly due to not signing, under some circumstances the overlay server doesn't accept any tcp connections

I've notice out in the black that on no traffic available it errors out, any chance this could be a non descriptive response something like 'No ships passed through this system' instead please.