Comments (9)
insin
commented on August 11, 2024
Here's Firefox 47 for me using the deployed version:
from react-hn.
addyosmani
commented on August 11, 2024
Thanks @insin! I wonder if this issue is resolved for @wanderview now too. Might have been temporary.
from react-hn.
insin
commented on August 11, 2024
/newcomments is sensitive to whatever's happening right now on HN, as on initial load it'll keep showing a spinner until somebody creates/updates a comment and its id appears on https://hacker-news.firebaseio.com/v0/updates, then it'll be live from that point onwards in the current session.
Just reading the component/UpdateStore code makes me want to rewrite it 🐱
from react-hn.
wanderview
commented on August 11, 2024
The top level comments do work for me with default settings. Its only when I check "offline mode" do they stop working. This happens for me across all platform and browser configurations.
Devtools shows this in the console:
HNServiceRest.js:37 Uncaught (in promise) TypeError: l(...).once is not a function(…)
from react-hn.
wanderview
commented on August 11, 2024
from react-hn.
addyosmani
commented on August 11, 2024
@wanderview I can repro this in offline mode now in both FF and Chrome. Marking as a bug and will look into a patch.
from react-hn.
addyosmani
commented on August 11, 2024
I have a patch locally that I believe fixes this. Deployed to https://react-hn-comments.appspot.com. @wanderview would you mind testing that with Offline Mode enabled please? 🍬
from react-hn.
wanderview
commented on August 11, 2024
Works great. Thanks!
from react-hn.
addyosmani
commented on August 11, 2024
🎉 🎈 🚢 Yay!
Thanks for confirming. I'll get the patch landed soon.
from react-hn.
Related Issues (20)
- LINK SEEMS DOWN HOT 2
- Add a section for stories you've looked at HOT 1
- Investigate using Lighthouse HOT 1
- Offline mode is broken HOT 5
- fresh repo clone fails during postinstall HOT 4
- Error - Not able to do 'npm run build' HOT 4
- manifest.d41d8cd9.js:1 Uncaught SyntaxError: Unexpected token <
- lighthouse: 'URL responds with a 200 when offline' doesn't pass HOT 2
- Points is not consistent
- Top stories HOT 1
- npm install fails HOT 2
- Sourcemap seems to be HTML
- Experiment: port over to using sw-helpers
- Question: react-router HOT 2
- Reloading development server HOT 1
- [email protected]: Failed to load resource: net::ERR_UNSAFE_REDIRECT
- Module not found: Error: Cannot resolve module 'history/lib/createHashHistory' HOT 1
- Why does show the first page items, then show blinking dots, then show the items again?
- WC HOT 2
- Live link down HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-hn.