Giter VIP home page Giter VIP logo

react-hn's Introduction

A React & react-router-powered implementation of Hacker News using its Firebase API.

react-hn screenshot

Live version: https://insin.github.io/react-hn

Features

  • Supports display of all item types: stories, jobs, polls and comments
  • Basic user profiles
  • Collapsible comment threads, with child counts
  • "Realtime" updates (free via Firebase!)
  • Last visit details for stories are cached in localStorage
  • New comments are highlighted:
    • Comments since your last visit to an item
    • New comments which load while you're reading an item
    • New comments in collapsed threads
  • Automatic or manual collapsing of comment threads which don't contain any new comments
  • Manual highlighting of the X most recent comments to catch up on threads you were reading elsewhere
  • Stories with new comments are marked on list pages
  • Stories can be marked as read to remove highighting from new comments
  • "comments" sections driven by the Changed Items API
  • Story listing pages are cached in sessionStorage for quick back button usage and pagination in the same session
  • Configurable settings:
    • auto collapse - automatically collapse comment threads without new comments on page load
    • show reply links - show "reply" links to Hacker News
    • show dead - show items flagged as dead
    • show deleted - show comments flagged as deleted in threads
  • Delayed comment detection - so tense! Who will it be? What will they say?

Feature requests are welcome!

Building

Install dependencies:

npm install

npm scripts

  • npm start - start development server
  • npm run build - build into the dist/ directory
  • npm run lint - lint src/
  • npm run lint:fix - lint src/ and auto-fix issues where possible

MIT Licensed

react-hn's People

Contributors

addyosmani avatar dopm avatar greenkeeperio-bot avatar insin avatar kambleaa007 avatar nekr avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

react-hn's Issues

Improve caching strategy

I love this app, thanks for building it! But it's missing the mark in an important way. Let me explain...

For me, HN links have a binary utilization profile, by which I mean that I generally click a link exactly zero or one times. Caching on access is useless for me because I don't tend to revisit previously read articles. And the lack of pre-caching means I get the dreaded dinosaur whenever I click on a link I've never visited.

What I'd really like is the following strategy: for every link presented, pre-fetch and cache the article for that link, so that when I'm on the train later and I'm reviewing the front page downloaded earlier, I can click a link and have a true offline "magic moment", where I'm presented with content I've never visited before.

I realize this will cause a high level of cache utilization, but I think it's ok to have a fairly short time to live for these pre-cached items. The HN front page changes frequently enough that the links for the top articles will most likely be gone within 24-48 hours so these pre-cached items can be purged fairly aggressively.

This will also burn a lot of network utilization, which might be impolite for people with limited and/or expensive data plans, but that could be addressed by having a config setting to selectively enable this pre-caching policy.

Update deployed URL in repo to reflect AppEngine hosted version

The latest version of the app with universal rendering is now up at https://react-hn.appspot.com. I have a few more optimisations locally that I need to PR back in over the coming days, but if we'd like to update the URL in the GitHub 'site'/link field for the repo, please feel free to use it :)

@insin What's the best email address to use if I'd like to add you to the AppEngine instance where this is hosted? I'd be happy to share deployment instructions so you can still update as/when you'd like (it's a 2 liner in the terminal).

Firebase integration

Hi,

Looks good!

Can I ask how you integrated with Firebase for "realtime" news updates?

Does your Application Server keep track of all client subscriptions and send and individual news message to each of them or have you been able to utilize FCM's topic broadcast capability?

Add a dark mode

I read HN at night in bed, so a dark theme is essential for me. This is better than any of the android HN apps out there, so I'd really like to switch to it full time.

I can contribute, but I'll need a little bit of direction on how to accomplish this.

Thanks, this is really slick. Especially saving it to my home screen on my phone!

Investigate using Lighthouse

Few diff directions this could take. Could just be an optional local run post-build. Could be something in CI. Going to kick the tires a little ๐Ÿš—

Revisit how comment threads are modelled and rendered

Is there any benefit to be gained from modelling comment threads in a way which allows rendering to deal with all comments as siblings, rather than nesting?

The current implementation isn't pretty - it started out as the simplest thing which would work with stuff continually bolted on top to support features like new comment highlighting and folding.

Implement a "threads" section

Allow users to specify their HN username and create a "threads" section with the comment ids from their profile data.

We could also potentially implement new reply notification by watching the first page worth of their comments (or slice it by date, or something else).for new comments.

Error - Not able to do 'npm run build'

Environment

MacOS Sierra - 10.12.1 Beta (16B2548a)

node v7.0.0

npm v3.10.9

Getting below error when running npm run build after cloning the repo and npm install

./node_modules/eslint-config-jonnybuchanan/bin/lint.js src

cp: dist/sw-toolbox.js: No such file or directory

npm ERR! Darwin 16.1.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "build"
npm ERR! node v7.0.0
npm ERR! npm v3.10.9
npm ERR! code ELIFECYCLE
npm ERR! [email protected] build: npm run lint && cp node_modules/sw-toolbox/sw-toolbox.js dist/sw-toolbox.js && ./node_modules/.bin/nwb build && npm run copy-manifest && npm run precache
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] build script 'npm run lint && cp node_modules/sw-toolbox/sw-toolbox.js dist/sw-toolbox.js && ./node_modules/.bin/nwb build && npm run copy-manifest && npm run precache'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the react-hn package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! npm run lint && cp node_modules/sw-toolbox/sw-toolbox.js dist/sw-toolbox.js && ./node_modules/.bin/nwb build && npm run copy-manifest && npm run precache
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs react-hn
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls react-hn
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR! /Users/anoopmundathan/projects/web/lab/react-hn/npm-debug.log

npm-debug-log file

0 info it worked if it ends with ok
1 verbose cli [ '/usr/local/bin/node', '/usr/local/bin/npm', 'run', 'build' ]
2 info using [email protected]
3 info using [email protected]
4 verbose run-script [ 'prebuild', 'build', 'postbuild' ]
5 info lifecycle [email protected]prebuild: [email protected]
6 silly lifecycle [email protected]
prebuild: no script for prebuild, continuing
7 info lifecycle [email protected]build: [email protected]
8 verbose lifecycle [email protected]
build: unsafe-perm in lifecycle true
9 verbose lifecycle [email protected]build: PATH: /usr/local/lib/node_modules/npm/bin/node-gyp-bin:/Users/anoopmundathan/projects/web/lab/react-hn/node_modules/.bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/ImageMagick/bin
10 verbose lifecycle [email protected]
build: CWD: /Users/anoopmundathan/projects/web/lab/react-hn
11 silly lifecycle [email protected]build: Args: [ '-c',
11 silly lifecycle 'npm run lint && cp node_modules/sw-toolbox/sw-toolbox.js dist/sw-toolbox.js && ./node_modules/.bin/nwb build && npm run copy-manifest && npm run precache' ]
12 silly lifecycle [email protected]
build: Returned: code: 1 signal: null
13 info lifecycle [email protected]~build: Failed to exec build script
14 verbose stack Error: [email protected] build: npm run lint && cp node_modules/sw-toolbox/sw-toolbox.js dist/sw-toolbox.js && ./node_modules/.bin/nwb build && npm run copy-manifest && npm run precache
14 verbose stack Exit status 1
14 verbose stack at EventEmitter. (/usr/local/lib/node_modules/npm/lib/utils/lifecycle.js:255:16)
14 verbose stack at emitTwo (events.js:106:13)
14 verbose stack at EventEmitter.emit (events.js:191:7)
14 verbose stack at ChildProcess. (/usr/local/lib/node_modules/npm/lib/utils/spawn.js:40:14)
14 verbose stack at emitTwo (events.js:106:13)
14 verbose stack at ChildProcess.emit (events.js:191:7)
14 verbose stack at maybeClose (internal/child_process.js:877:16)
14 verbose stack at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
15 verbose pkgid [email protected]
16 verbose cwd /Users/anoopmundathan/projects/web/lab/react-hn
17 error Darwin 16.1.0
18 error argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "build"
19 error node v7.0.0
20 error npm v3.10.9
21 error code ELIFECYCLE
22 error [email protected] build: npm run lint && cp node_modules/sw-toolbox/sw-toolbox.js dist/sw-toolbox.js && ./node_modules/.bin/nwb build && npm run copy-manifest && npm run precache
22 error Exit status 1
23 error Failed at the [email protected] build script 'npm run lint && cp node_modules/sw-toolbox/sw-toolbox.js dist/sw-toolbox.js && ./node_modules/.bin/nwb build && npm run copy-manifest && npm run precache'.
23 error Make sure you have the latest version of node.js and npm installed.
23 error If you do, this is most likely a problem with the react-hn package,
23 error not with npm itself.
23 error Tell the author that this fails on your system:
23 error npm run lint && cp node_modules/sw-toolbox/sw-toolbox.js dist/sw-toolbox.js && ./node_modules/.bin/nwb build && npm run copy-manifest && npm run precache
23 error You can get information on how to open an issue for this project with:
23 error npm bugs react-hn
23 error Or if that isn't available, you can get their info via:
23 error npm owner ls react-hn
23 error There is likely additional logging output above.
24 verbose exit [ 1, true ]

Service Worker: add support for Cache expiration

In Offline Mode, we could take advantage of the sw-toolbox Cache Expiration feature to limit how long story and comment threads get offline cached.

This is useful if you've been using the app for a few weeks, have built up a large offline cache of content and would prefer that we only keep stories/comments stored for a week or something like that.

At build time, concat vendor/app scripts and async load in

Basically, over in this: https://github.com/insin/react-hn/blob/master/src/views/index.ejs#L37

We want to concatenate both vendor and app scripts into a single bundle so at build time instead of:

    <script src="build/vendor.js"></script>
    <script src="build/app.js"></script>

We're just doing:

    <script src="build/bundle.js" async></script>

to avoid blocking.

An alternative to this approach would be ignoring concatenation and just focusing on our HTTP/2 story. I haven't deployed HTTP/2 with push support on AppEngine before, but could learn how to do so if we wanted it.

My app shell disappears and reappears on page reload, why?

I used this PWA as an example using SW precache v2 in my React App and webpack. However, I am not getting the same results. My app works offline. but on page reload everything from the DOM disappears and gets fetched again, the results do come from the service worker: (see photo below). In contrast this app and thesession.org app dont even make a request on page reload. What I'm I missing?
app_network_frames-timeline

Error in app start-up

I did npm install, npm run build and then npm start

agniva-~/play/react-hn$npm start

> [email protected] start /home/agniva/play/react-hn
> node server.js

module.js:327
    throw err;
    ^

Error: Cannot find module 'babel/register'
    at Function.Module._resolveFilename (module.js:325:15)
    at Function.Module._load (module.js:276:25)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/home/agniva/play/react-hn/server.js:6:1)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Function.Module.runMain (module.js:441:10)

npm ERR! Linux 4.2.0-16-generic
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "start"
npm ERR! node v4.3.2
npm ERR! npm  v2.14.12
npm ERR! code ELIFECYCLE
npm ERR! [email protected] start: `node server.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] start script 'node server.js'.
npm ERR! This is most likely a problem with the react-hn package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node server.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls react-hn
npm ERR! There is likely additional logging output above.

My node version is 4.3.2. Do I need to upgrade ?

Cannot find module 'babel/register'

Wondering if we are missing babel dependencies. I get below error when I run npm i && npm start

โšก npm start
> [email protected] start /Users/csekharveera/Sites/react-hn
> node server.js

module.js:440
    throw err;
    ^

Error: Cannot find module 'babel/register'
    at Function.Module._resolveFilename (module.js:438:15)
    at Function.Module._load (module.js:386:25)
    at Module.require (module.js:466:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/csekharveera/Sites/react-hn/server.js:8:1)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:456:32)
    at tryModuleLoad (module.js:415:12)
    at Function.Module._load (module.js:407:3)

npm ERR! Darwin 14.5.0
npm ERR! argv "/Users/csekharveera/.nvm/versions/node/v6.1.0/bin/node" "/Users/csekharveera/.nvm/versions/node/v6.1.0/bin/npm" "start"
npm ERR! node v6.1.0
npm ERR! npm  v3.8.6
npm ERR! code ELIFECYCLE
npm ERR! [email protected] start: `node server.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] start script 'node server.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the react-hn package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node server.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs react-hn
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls react-hn
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/csekharveera/Sites/react-hn/npm-debug.log

Offline support in Firefox

I was impressed with the demo @addyosmani did at IO 2016. Offline support works perfectly in Chrome. I cannot get it working in latest FF 46, although according to Jake Archibald's status page the service workers support in FF as good as in Chrome. Maybe the libraries that were used (sw-toolkit and sw-precache) have some issues or it is the lack of testing in FF?

I noticed that both offline features don't work:

  • refreshing the home page in offline mode
  • opening the cached comments page.

Support caching comment-threads / page content offline

I previously added support for caching the react-hn application shell and static assets using Service Worker. This gave us a little bit of offline support, but the bigger missing piece here was caching comment threads and general responses coming back from the Firebase API. Let's fix that ๐Ÿ”ง

Firebase's default offline support unfortunately only works during an individual session, so as soon as you close a tab or try relaunching the app from say - your Service Worker cache - it's still going to try reaching out to the network. This kills our ability to have comment pages fully work offline.

To address this, I've been working on a minimal read-only caching module that sits on top of Firebase that caches responses coming back from on(), once(), child() and so on using localForage (i.e IndexedDB in most modern browsers). I'll be PR'ing in a change that introduces this shortly.

Upgrade to be a Progressive Web App

I've been investigating how we could turn ReactHN into a Progressive Web App with some offline support using Service Workers.

Some of the specific benefits this would bring include quicker time-to-interactive (if I make a few architectural changes), faster first paint/load for subsequent visits and a slightly more pleasant 'add to homescreen' experience for folks using react-hn on mobile (e.g Chrome on Android). The latter can be accomplished using a Web App Manifest. I'd be happy to PR one in (they look like this).

There's https://github.com/GoogleChrome/sw-precache for generating a Service Worker of files to precache so we can move towards instant loading on repeat visits and offline support. I've used this successfully in a bunch of projects. Given we're using WebPack here, we could also use offline-plugin by @NekR to ease some support for SW in. I guess that's something you could try incorporating into https://github.com/insin/nwb/blob/master/src/createWebpackConfig.js if interested via the webpack config object.

Happy to chat more if interested in the updates needed to make this happen.

Btw: Because we're using Firebase as the backend, we'll need to spend a while figuring out how to properly make those responses work offline as Firebase is currently limited to offline providing offline support for the current session - not once the user has returned to the app or launched the fullscreen PWA.

Investigate support for Universal/Isomorphic rendering

In the application shell architecture, we try to encourage server-side rendering for fast first paint as much as possible. Even if just for the "shell"/common user interface.

In our current version of react-hn in master, we still rely on client-side rendering to display any content. We can probably do way better here so a static render gives us something useful on the screen.

I would love to see what we can do to explore Universal rendering support and what perf gains this would bring. We would want this to play as nicely as possible with our Service Worker caching but..good to get a start on a PR to see what a V0 take on this would look like.

cc @jackfranklin @Garbee @zenorocha who may be interested in helping with this or have a few pointers ๐Ÿฐ

Update all dependencies to latest (including syntax)

The currently deployed build should be working fine, but our deps changed a bit since we did a release. A little work to do:

  • Firebase 2.0 -> 3.0
  • Latest stable React Router
  • Latest nwb with Webpack
  • Reach parity with master feature-set
  • Trim vendor build by switching to modular Firebase pieces

Reloading development server

I am trying to run a development server locally and code doesn't appear to reload code in the browser on save of file or on reload of browser. This happens when I run the server with npm run start.

Alternatively I have tried running a development server using nwb with npm run serve and then the code reloading does work. However, in this case no css is loaded and the index html is more bare than expected and of providence that I can't figure out:

<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
    <meta http-equiv="x-ua-compatible" content="ie=edge">
    <title>react-hn</title>
  </head>
  <body>
    <div id="app"></div>
  <script type="text/javascript" src="/core.js"></script><script type="text/javascript" src="/app.js"></script></body>
</html>

I am running this on MacOS

$ npm --version
4.6.1
$ node --version
v6.10.3

npm install fails

I tried to run build this project on Windows 8.1 but it fails:

D:\3rdparty\react-hn>npm install

> [email protected] install D:\3rdparty\react-hn\node_modules\nwb\node_m
odules\phantomjs-prebuilt
> node install.js

PhantomJS not found on PATH
Downloading https://github.com/Medium/phantomjs/releases/download/v2.1.1/phantom
js-2.1.1-windows.zip
Saving to C:\Users\me\AppData\Local\Temp\phantomjs\phantomjs-2.1.1-windows.zip
Receiving...
  [=======================================-] 96%
Received 17767K total.
Extracting zip contents
Removing D:\3rdparty\react-hn\node_modules\nwb\node_modules\phantomjs-prebuilt\l
ib\phantom
Copying extracted folder C:\Users\me\AppData\Local\Temp\phantomjs\phantomjs-2.1.
1-windows.zip-extract-1484707321737\phantomjs-2.1.1-windows -> D:\3rdparty\react
-hn\node_modules\nwb\node_modules\phantomjs-prebuilt\lib\phantom
Writing location.js file
Done. Phantomjs binary available at D:\3rdparty\react-hn\node_modules\nwb\node_m
odules\phantomjs-prebuilt\lib\phantom\bin\phantomjs.exe

> [email protected] postinstall D:\3rdparty\react-hn\node_modules\nwb\node_modul
es\spawn-sync
> node postinstall


> [email protected] postinstall D:\3rdparty\react-hn
> npm run build


> [email protected] build D:\3rdparty\react-hn
> mkdir -p dist && npm run lint && cp node_modules/sw-toolbox/sw-toolbox.js dist
/sw-toolbox.js && ./node_modules/.bin/nwb build && npm run copy-manifest && npm
run precache


> [email protected] lint D:\3rdparty\react-hn
> ./node_modules/eslint-config-jonnybuchanan/bin/lint.js src

'.' is not recognized as an internal or external command,
operable program or batch file.

npm ERR! Windows_NT 6.3.9600
npm ERR! argv "D:\\Program Files\\nodejs\\node.exe" "D:\\Program Files\\nodejs\\
node_modules\\npm\\bin\\npm-cli.js" "run" "lint"
npm ERR! node v6.9.3
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR! [email protected] lint: `./node_modules/eslint-config-jonnybuchanan/bin/li
nt.js src`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] lint script './node_modules/eslint-config-
jonnybuchanan/bin/lint.js src'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the react-hn package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     ./node_modules/eslint-config-jonnybuchanan/bin/lint.js src
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs react-hn
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls react-hn
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     D:\3rdparty\react-hn\npm-debug.log

npm ERR! Windows_NT 6.3.9600
npm ERR! argv "D:\\Program Files\\nodejs\\node.exe" "D:\\Program Files\\nodejs\\
node_modules\\npm\\bin\\npm-cli.js" "run" "build"
npm ERR! node v6.9.3
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR! [email protected] build: `mkdir -p dist && npm run lint && cp node_modules
/sw-toolbox/sw-toolbox.js dist/sw-toolbox.js && ./node_modules/.bin/nwb build &&
 npm run copy-manifest && npm run precache`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] build script 'mkdir -p dist && npm run lin
t && cp node_modules/sw-toolbox/sw-toolbox.js dist/sw-toolbox.js && ./node_modul
es/.bin/nwb build && npm run copy-manifest && npm run precache'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the react-hn package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     mkdir -p dist && npm run lint && cp node_modules/sw-toolbox/sw-tool
box.js dist/sw-toolbox.js && ./node_modules/.bin/nwb build && npm run copy-manif
est && npm run precache
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs react-hn
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls react-hn
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     D:\3rdparty\react-hn\npm-debug.log

npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\nw
b\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@
1.0.14: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"
})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.0.0 (node_modules\nw
b\node_modules\chokidar\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@
1.0.17: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"
})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.0.0 (node_modules\ch
okidar\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@
1.0.17: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"
})
npm WARN [email protected] requires a peer of eslint@>=3.0.0 but
none was installed.
npm WARN [email protected] requires a peer of eslint@^2.10 || ^3.0 but
 none was installed.
npm WARN [email protected] requires a peer of eslint@>=3.0.0 but none
 was installed.
npm WARN [email protected] requires a peer of eslint@>=3.0.0 but none
 was installed.
npm WARN [email protected] requires a peer of eslint@>=3.0.0 bu
t none was installed.
npm WARN [email protected] requires a peer of eslint@^2.0.0 || ^3.0.0 bu
t none was installed.
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "D:\\Program Files\\nodejs\\node.exe" "D:\\Program Files\\nodejs\\
node_modules\\npm\\bin\\npm-cli.js" "install"
npm ERR! node v6.9.3
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR! [email protected] postinstall: `npm run build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] postinstall script 'npm run build'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the react-hn package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run build
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs react-hn
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls react-hn
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     D:\3rdparty\react-hn\npm-debug.log

My versions are:

>node --version
v6.9.3

>npm --version
3.10.10

Add Google Analytics tracking

Prior to a full 'relaunch' of ReactHN as a Progressive Web App, I think it'd be useful to add in GA tracking ๐Ÿ™ˆ

This might help us understand who our audience are, what devices/browsers they're accessing us with and help get some other insights that might be useful for the future.

Will throw together a PR once I've setup an account and added @insin.

[Firefox] Navigation > Comments page is slow to load

I haven't been able to repro this in other browsers, but in Firefox (desktop) the top-level Comments page takes a long time to return any data. It works fine with all our other views.

Video: http://recordit.co/uKni7RWp9n
Versions tested: FF 46, 47, 50

Oddly, it works absolutely fine in Firefox for Android (stable).

Similarly odd, testing locally, we have no issues loading this page as quickly as any other in FF50:

screen shot 2016-06-28 at 13 36 50

Paging @wanderview in case he has more information available that would help with repros.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.