interactivethings / d3-comparator Goto Github PK

If an accessor is a string it could denote a property name. Use it to access that property:

var cmp = d3.comparator().dimension(d3.ascending, 'value');

This is similar to Underscore's _.pluck()

Careful with that identity function: it's defined outside the closure and will pollute the global namespace or be overridden by someone else, if they define a function with the same name.

Does it really depend on d3 version 3? It looks like it would just as well run with earlier versions… Maybe create a test for them and allow its use for those versions also.

Add a makefile to run tests, create a minified version and publish to npm

Not 100% sure but

d3.comparator()
  .sort(d3.descending, accessor)
  .sort(d3.ascending, accessor2);

seems more eloquent than

d3.comparator()
  .dimension(d3.descending, accessor)
  .dimension(d3.ascending, accessor2);