intlify / routing Goto Github PK

Clear and concise description of the problem

Other Open Graph tags, like og:title, og:description, etc. can and should be added separately from i18n, but given the logic included in this package of turning localized routes into linkand meta tags, it would be great to generate the og:url metadata in additional to the already generated og:locale ones, so that systems relying on Open Graph (e.g. Facebook scrapers) are satisfied.

Suggested solution

In /src/compatibles/head.ts, rewrite addCanonicalLinks into addCanonicalLinksAndOgUrl

Alternative

• Write a separate addOgUrl function, but most of the logic / intermediate steps would be the same as addCanonicalLinks
• Add a new config parameter addOgUrl: boolean to maximize flexibility: thought it wasn't necessary

Additional context

See https://developers.facebook.com/docs/sharing/webmasters/#basic

Validations

• Follow our Code of Conduct
• Read the Contributing Guide.
• Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• chore(deps): replace dependency npm-run-all with npm-run-all2 ^5.0.0
• chore(deps): update dependency eslint to v9
• chore(deps): update dependency globby to v14
• chore(deps): update dependency happy-dom to v14
• chore(deps): update dependency vite to v5
• chore(deps): update dependency vitest to v1
• chore(deps): update dependency vue-i18n-legacy to v9
• chore(deps): update dependency vue-router3 to v4
• chore(deps): update dependency vue-tsc to v2
• chore(deps): update stefanzweifel/git-auto-commit-action action to v5
• chore(deps): update typescript-eslint monorepo to v7 (major) (@typescript-eslint/eslint-plugin, @typescript-eslint/parser)
• fix(deps): update dependency @vueuse/head to v2
• fix(deps): update dependency vue-i18n to v9.13.1
• fix(deps): update dependency vue-i18n-routing to v1
• fix(deps): update dependency vue-router to v4.3.2
• fix(deps): update vue monorepo to v3 (major) (vue, vue2)
• 🔐 Create all rate-limited PRs at once 🔐

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency @vue/tsconfig to v0.5.1
• chore(deps): update dependency playwright to v1.44.0
• chore(deps): update vue monorepo (@vue/runtime-dom, vue, vue-template-compiler, vue2)
• fix(deps): update dependency vue-router to v3.6.5
• chore(deps): update dependency @types/node to v20
• chore(deps): update dependency @vitejs/plugin-legacy to v5
• chore(deps): update dependency @vitejs/plugin-vue to v5
• chore(deps): update dependency @vitejs/plugin-vue-jsx to v3
• chore(deps): update dependency rimraf to v5
• chore(deps): update dependency typescript to v5
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Hi! I need to pass props to a route, but to do it I need to use the name of the route, and the library modifies it.

I tried to use localeLocation, and when running it inside a template it works correctly.
My problem is that I need it to work inside the script block (I'm using vue3 with composition api, and the script setup syntax).

When using the function localeLocation inside the script, it tells me that it does not exist, when importing it (which I do not need to do when using it inside the template) and running the function it returns me that it cant find 'router', but I can not pass it to the function.
What can I do to be able to use parameters with this library?

My project is configured like the playground vue3 project

<script setup lang="ts">
// Does not work
console.log(localeLocation({ name: 'about', params: { test: 'hola' } } ))
</script>

<template>
  <!-- Does work -->
  <pre>{{ localeLocation({ name: 'about', params: { test: 'hola' } }) }}</pre>
</template>

Not Found - GET https://registry.npmjs.org/vue-i18n-switch - Not found

Describe the bug

When mounting a component that uses useRoute() or useRouter() with vue-test-utils and a vue-i18n-router, the useRoute and useRouter composables do not return any values. Instead the following error will be printed:

[Vue warn]: injection "Symbol(route location)" not found. 
  at <HelloWorld ref="VTU_COMPONENT" > 
  at <VTUROOT>

When using a vue-router instead of the vue-i18n-router everything is working as expected.

Reproduction

https://stackblitz.com/edit/vitejs-vite-vckr8m?file=tests%2FSample.spec.js

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (2) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.18.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.3 - /usr/local/bin/pnpm

Used Package Manager

npm

Additional context

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guide.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
• The provided reproduction is a minimal reproducible of the bug.

Describe the bug

I'm on Vue 3, and require vue-i18n-routing 0.7.0 in my package.json.

When I run pnpm i --no-optional, I get the following error message:

Reproduction

Cannot reproduce on stackblitz, please advice.

System Info

System:
    OS: Linux 5.15 Ubuntu 22.04.1 LTS 22.04.1 LTS (Jammy Jellyfish)
    CPU: (24) x64 AMD Ryzen 9 5900X 12-Core Processor
    Memory: 46.74 GB / 62.74 GB
    Container: Yes
    Shell: 5.8.1 - /usr/bin/zsh
  Binaries:
    Node: 18.11.0 - ~/.nvm/versions/node/v18.11.0/bin/node
    npm: 8.19.2 - ~/.nvm/versions/node/v18.11.0/bin/npm
  Browsers:
    Firefox: 106.0

Used Package Manager

[email protected]

Additional context

.npmrc

audit=false
engine-strict=true
loglevel=error
fund=false
node-linker=hoisted
prefer-offline=true
progress=false
shamefully-hoist=true
store-dir=.pnpm-store
strict-peer-dependencies=true
update-notifier=false

Validations

• Follow our Code of Conduct
• Read the Contributing Guide.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
• The provided reproduction is a minimal reproducible of the bug.

Clear and concise description of the problem

I'm using a modified version of nuxt-seo-kit and I'm using it's breadcrumbs
I have modified it to include or omit language codes in the breadcrumb it creates

the problem is, on main page, I have to have a way to detect and omit the default locale's language code for the main page, since default language does not include language code in it's url

currently there's no way to get the defaultLocale set in the config that I'm aware of, cleanly (without using some env variable)

Suggested solution

expose it using a composable ? I'm not sure what's the best way to expose it.

Alternative

the alternative is to simply use runtime config

it won't be clean and it can't be included in a PR for nuxt-seo-kit

Additional context

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guide.
• Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Description

When utilizing the localePath function by passing a string with a route containing query parameters, such as /some-route?foo=bar, the query parameters are unexpectedly removed. This behavior occurs only when the route exists.

Steps to Reproduce

1. Use the localePath function with a route containing query parameters as a string argument.
2. Observe that the resulting route does not include the query parameters.

Code illustration

const path = '/some-route?foo=bar';
const route = localePath(path);
// The expected output should include the query parameters, but they are omitted.
// Result: "/en/some-route"

Reason

Upon investigation, the query parameters removal occurs in the vue-i18n-routing/src/compatibles/routing.ts file, specifically in the following code snippet:

// vue-i18n-routing/src/compatibles/routing.ts line 232
const resolvedRoute = router.resolve(localizedRoute) as any

At this point, the localizedRoute is in the format:

{
  path: "/en/some-route?foo=bar",
}

As a result, the query parameters are inadvertently removed from the route.

A possible solution

An observation has been made that the behavior of the router.resolve() function differs when a string is passed versus when an object with a path property is passed. The former retains the query parameters, while the latter removes them.

const router = useRouter()
const path = '/en/some-route?foo=bar'
const routeResolvedFromString = router.resolve(path)
// returns {
//  "fullPath": "/en/some-route?foo=bar",
//  "path": "/en/some-route",
//  "query": { "foo": "bar" },
//  ...
// }

const routeResolvedFromObject = router.resolve({ path })
{
  "fullPath": "/en/some-route",
  "path": "/en/some-route",
  "query": {},
  ...
}

It's unclear whether this behavior is rooted in the vue-router library, but this information could potentially offer a workaround to mitigate the issue.

Reproduction

https://stackblitz.com/edit/nuxt-starter-vbbhvz?file=pages%2Findex.vue

System Info

System:
    OS: macOS 13.5
    CPU: (8) arm64 Apple M1
    Memory: 101.73 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 16.20.1 - /usr/local/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 9.6.7 - /opt/homebrew/bin/npm
    pnpm: 7.30.0 - /opt/homebrew/bin/pnpm
  Browsers:
    Chrome: 113.0.5672.126
    Safari: 16.6
    Safari Technology Preview: 17.0

Used Package Manager

yarn

Additional context

Problem first noticed in Nuxt 3.5.3 with @nuxtjs/i18n 8.0.0-rc.2 with this configuration:

  i18n: {
    locales: [
      {
        code: 'fr',
        name: 'Français',
        iso: 'fr-BE',
      },
      {
        code: 'en',
        name: 'English',
        iso: 'en-US',
      },
    ],
    defaultLocale: 'fr',
    strategy: 'prefix',
    dynamicRouteParams: true,
  },

Validations

• Follow our Code of Conduct
• Read the Contributing Guide.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
• The provided reproduction is a minimal reproducible of the bug.