Giter VIP home page Giter VIP logo

asset-directory's People

Contributors

albertandrejev avatar andreas-barthel avatar davepuchyr avatar iharob avatar joeyoshop avatar rohitjain00 avatar stephiov avatar xpt1x avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

asset-directory's Issues

Add CI

CI should be there with basic tests/checks related to addition to assets

  • Must include verification of added asset's symbol existence on coingecko
  • Should check if every asset has required props ( can be done with tsc )

Add support for different coin networks

Project currently stores asset with their key being asset's symbol, which creates conflict when same coin is registered with same symbols on different networks

We should find a way to support assets on multiple networks
For example:

{ 
   id: "usd-coin", 
   symbol: "usdc", 
   name: "USD Coin" 
},
{
   id: "usd-coin-avalanche-bridged-usdc-e",
   symbol: "usdc",
   name: "USD Coin Avalanche Bridged (USDC.e)",
},

Are 2 different coins but with same symbol and are on different network

Rename `Multi-collateral DAI` to `DAI Stablecoin`

People can't find DAI in the Starname Manager's list of coins because we have it named Multi-collateral DAI. People just look for DAI and, since the coin list is sorted alphabetically, they don't find our Multi-collateral DAI.

Simplify structure of whole project

  • Drop UCRegistry as its an obsolete package now
  • Remove usage of caip19 prop for assets as we were using it just for integration with wallets but we already have this on manager with IBC config
  • Have asset's data in its own directory ( dont use separate metadata dirs for each asset )
  • Check status of each asset beforehand if found in trustwallet asset ( like active or abandoned ) discard abandoned letting user know
  • Check asset symbol on coinGecko first else exit with msg
  • Simplify aggregation script
  • Add support of TypeSscript ( thus easy imports )

We will still use trustwallet as a submodule as we rely on their info just to make it easy on the user but we will surely have the option to override things and provide manually... if we dont agree on naming / other prop for an asset

Query coingecko api first

Coingecko api should be queried first

Advantages:

  • Will prevent breaking.. payment behaviour of starname app
  • Found coin's name after api call can be used as a fallback name if not found on trustwallet registry and should be showed to user for suggestion

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.