TestHandshake fails occasionally about kubo HOT 11 CLOSED

Im glad im not crazy, i ran into this once. Havent been able to get a repro since.

from kubo.

I'll continue to report test failures as I discover them. I hope that collecting them will help

ps. To help with investigation, I'll also make sure to include the commit hash of the code that failed.

from kubo.

This one is

6f82f7b

https://travis-ci.org/jbenet/go-ipfs/jobs/35159633

from kubo.

Yeah, there's another random error I get "malformed public key" every so often.

from kubo.

This deadlock is weird. There should be two goroutines in the Handshake method (and two sets of secure I/O). Im only seeing one... One must have somehow failed, but didnt end up causing a t.Fatal to trigger. Im gonna throw some panics in and run the test until i can repro a failure.

from kubo.

It was on feat/bitswap-internal-notifications at 6f82f7b

from kubo.

I was also able to reproduce it once after switching to master. 20 runs later, no luck with a repro

from kubo.

Looks like deadlock occurs when:

• peer a's handshake fails silently, peer b signals finished (identify.go:156) and waits on secureIn for a response(identify.go:157)

I found some spots where errors are ignored. Adding error handling. Will open a PR.

from kubo.

@jbenet Is there a spec for the handshake anywhere?

from kubo.

should have been fixed in #128

from kubo.

Though, see: #130

from kubo.