ipublikuj-archive / assets-loader Goto Github PK

does it depends on other class or command line tool?

File: ...\src\IPub\AssetsLoader\Filters\Files\LessFilter.php:70

60:
61: /**
62: * Get less compiler
63: *
64: * @return \lessc
65: */
66: protected function getLessC()
67: {
68: // Lazy loading
69: if (!$this->lc) {
70: $this->lc = new \lessc();
71: }
72:
73: return $this->lc;
74: }

Hi,
is shortening paths really required in https://github.com/iPublikuj/assets-loader/blob/master/src/IPub/AssetsLoader/Diagnostics/Panel.php#L81?

It won't even work properly when defining in bootstrap.php like this:

define('WWW_DIR', __DIR__ . '/../');

A suggestion in config.neon when

assetsLoader:
    routes: null

the extension wouldn't then be prepending routes to router. I am asking because I want to serve the files via https.

My current workaround is very hacky / ugly:

assetsLoader:
    routes:
        assets: http://
        files: http://

The routes won't ever match. Then I append custom route in RouterFactory.

Should I prepare a pull or you want to keep current behavior?