irccloud / irccloud-desktop Goto Github PK

IRCCloud Desktop App

License: Apache License 2.0

JavaScript 99.14% Makefile 0.86%

irc chat irccloud desktop-app electron windows mac linux cross-platform

irccloud-desktop's Introduction

IRCCloud Desktop

⚠️ This app is now discontinued and will no longer be updated. Instead, we recommend you install the IRCCloud website as an app using your browser.

Development

IRCCloud Desktop is built on the Electron app framework, as used by GitHub's Atom editor. For more information, check out the Electron documentation. Build and packaging is handled by the excellent electron-builder project.

Build Requirements

Node JS version >= 12.13.1
yarn (recommended) or NPM (should also work fine)

On Linux, you also need the libopenjp2-tools package.

Running

Run make dev in the root of the repository to run the app quickly (without icons).

To build a full version, make dist.

Instructions for building packages and signed binaries on CI are at docs/OfficialBuilds.md

irccloud-desktop's People

Contributors

Stargazers

Watchers

irccloud-desktop's Issues

Find in page

This can be done with webviews.

See:

Make clicking notification bubbles switch to the buffer that triggered them? (Possibly invalid)

This actually may already work. I've not checked.

Mac fwd/back with mouse swipe/buttons

2-finger swipe navigation is enabled by electron/electron#4181 but will need some involved capturing of onwheel events.

3-finger swipe navigation is blocked on electron/electron#4843

AppImage does not work

me@host:~$ '/home/me/Downloads/irccloud-desktop-0.2.0.AppImage' 
/tmp/.mount_ti507O
installed: X-AppImage-Version=0.2.0.166 image: X-AppImage-Version=0.2.0.166
/tmp/.mount_ti507O/AppRun: line 46: /tmp/.mount_ti507O/usr/bin/irccloud: No such file or directory

Might be related to this.

Emocodes parsing expects a space around emocodes

Emocodes that don't have a space around them aren't rendered.

Example:
In github, great:thumbsup:thanks is rendered as

great:thumbsup:thanks

while in irccloud the same is rendered as
great:thumbsbup:thanks

Linux App on desktop.irccloud.com Lacks an Icon

It would be nice if the program had an icon or a launcher that one could search the dash for in ubuntu. Right now, makes my toolbar look ugly with the default icon.

"About" panel should be static HTML

Could just wget it during build?

Failing at install app deps

I am not able to run it. npm install gives this error -

[email protected] postinstall /Users/akka/dev/electronapps/irccloud-desktop/node_modules/electron-prebuilt
node install.js
undefined postinstall /Users/akka/dev/electronapps/irccloud-desktop
install-app-deps

Installing app dependencies for arch x64 to /Users/akka/dev/electronapps/irccloud-desktop/app
npm ERR! git rev-list -n1 saveas: fatal: ambiguous argument 'saveas': unknown revision or path not in the working tree.
npm ERR! git rev-list -n1 saveas: Use '--' to separate paths from revisions, like this:
npm ERR! git rev-list -n1 saveas: 'git <command> [<revision>...] -- [<file>...]'
npm ERR! git rev-list -n1 saveas:
npm ERR! git rev-list -n1 saveas: fatal: ambiguous argument 'saveas': unknown revision or path not in the working tree.
npm ERR! git rev-list -n1 saveas: Use '--' to separate paths from revisions, like this:
npm ERR! git rev-list -n1 saveas: 'git <command> [<revision>...] -- [<file>...]'
npm ERR! git rev-list -n1 saveas:
npm ERR! git rev-list -n1 saveas: fatal: ambiguous argument 'saveas': unknown revision or path not in the working tree.
npm ERR! git rev-list -n1 saveas: Use '--' to separate paths from revisions, like this:
npm ERR! git rev-list -n1 saveas: 'git <command> [<revision>...] -- [<file>...]'
npm ERR! git rev-list -n1 saveas:
npm ERR! Darwin 15.6.0
npm ERR! argv "/Users/akka/.nvm/versions/node/v6.3.1/bin/node" "/Users/akka/.nvm/versions/node/v6.3.1/lib/node_modules/npm/bin/npm-cli.js" "install" "--production"
npm ERR! node v6.3.1
npm ERR! npm  v3.10.3
npm ERR! code 128

npm ERR! Command failed: git rev-list -n1 saveas
npm ERR! fatal: ambiguous argument 'saveas': unknown revision or path not in the working tree.
npm ERR! Use '--' to separate paths from revisions, like this:
npm ERR! 'git <command> [<revision>...] -- [<file>...]'
npm ERR!
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/akka/dev/electronapps/irccloud-desktop/app/npm-debug.log
Unhandled rejection Error: /Users/akka/.nvm/versions/node/v6.3.1/bin/node exited with code 1
    at ChildProcess.childProcess.on.code (/Users/akka/dev/electronapps/irccloud-desktop/node_modules/electron-builder/src/util/util.ts:132:14)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:852:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:215:5)
From previous event:
    at spawn (/Users/akka/dev/electronapps/irccloud-desktop/node_modules/electron-builder/src/util/util.ts:109:9)
    at spawnNpmProduction (/Users/akka/dev/electronapps/irccloud-desktop/node_modules/electron-builder/src/util/util.ts:43:9)
    at Object.installDependencies (/Users/akka/dev/electronapps/irccloud-desktop/node_modules/electron-builder/src/util/util.ts:21:120)
    at /Users/akka/dev/electronapps/irccloud-desktop/node_modules/electron-builder/src/install-app-deps.ts:30:2
    at next (native)
From previous event:
    at tsAwaiter (/Users/akka/dev/electronapps/irccloud-desktop/node_modules/electron-builder/src/util/awaiter.ts:10:47)
    at main (/Users/akka/dev/electronapps/irccloud-desktop/node_modules/electron-builder/src/install-app-deps.ts:23:3)
    at Object.<anonymous> (/Users/akka/dev/electronapps/irccloud-desktop/node_modules/electron-builder/src/install-app-deps.ts:35:7)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)
    at Module.runMain (module.js:575:10)
    at run (bootstrap_node.js:352:7)
    at startup (bootstrap_node.js:144:9)
    at bootstrap_node.js:467:3
> [email protected] postinstall /Users/akka/dev/electronapps/irccloud-desktop/node_modules/electron-prebuilt
> node install.js


> undefined postinstall /Users/akka/dev/electronapps/irccloud-desktop
> install-app-deps

Installing app dependencies for arch x64 to /Users/akka/dev/electronapps/irccloud-desktop/app

npm ERR! git rev-list -n1 saveas: fatal: ambiguous argument 'saveas': unknown revision or path not in the working tree.
npm ERR! git rev-list -n1 saveas: Use '--' to separate paths from revisions, like this:
npm ERR! git rev-list -n1 saveas: 'git <command> [<revision>...] -- [<file>...]'
npm ERR! git rev-list -n1 saveas:
npm ERR! git rev-list -n1 saveas: fatal: ambiguous argument 'saveas': unknown revision or path not in the working tree.
npm ERR! git rev-list -n1 saveas: Use '--' to separate paths from revisions, like this:
npm ERR! git rev-list -n1 saveas: 'git <command> [<revision>...] -- [<file>...]'
npm ERR! git rev-list -n1 saveas:
npm ERR! git rev-list -n1 saveas: fatal: ambiguous argument 'saveas': unknown revision or path not in the working tree.
npm ERR! git rev-list -n1 saveas: Use '--' to separate paths from revisions, like this:
npm ERR! git rev-list -n1 saveas: 'git <command> [<revision>...] -- [<file>...]'
npm ERR! git rev-list -n1 saveas:
npm ERR! Darwin 15.6.0
npm ERR! argv "/Users/akka/.nvm/versions/node/v6.3.1/bin/node" "/Users/akka/.nvm/versions/node/v6.3.1/lib/node_modules/npm/bin/npm-cli.js" "install" "--production"
npm ERR! node v6.3.1
npm ERR! npm  v3.10.3
npm ERR! code 128

npm ERR! Command failed: git rev-list -n1 saveas
npm ERR! fatal: ambiguous argument 'saveas': unknown revision or path not in the working tree.
npm ERR! Use '--' to separate paths from revisions, like this:
npm ERR! 'git <command> [<revision>...] -- [<file>...]'
npm ERR!
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/akka/dev/electronapps/irccloud-desktop/app/npm-debug.log
Unhandled rejection Error: /Users/akka/.nvm/versions/node/v6.3.1/bin/node exited with code 1
    at ChildProcess.childProcess.on.code (/Users/akka/dev/electronapps/irccloud-desktop/node_modules/electron-builder/src/util/util.ts:132:14)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:852:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:215:5)
From previous event:
    at spawn (/Users/akka/dev/electronapps/irccloud-desktop/node_modules/electron-builder/src/util/util.ts:109:9)
    at spawnNpmProduction (/Users/akka/dev/electronapps/irccloud-desktop/node_modules/electron-builder/src/util/util.ts:43:9)
    at Object.installDependencies (/Users/akka/dev/electronapps/irccloud-desktop/node_modules/electron-builder/src/util/util.ts:21:120)
    at /Users/akka/dev/electronapps/irccloud-desktop/node_modules/electron-builder/src/install-app-deps.ts:30:2
    at next (native)
From previous event:
    at tsAwaiter (/Users/akka/dev/electronapps/irccloud-desktop/node_modules/electron-builder/src/util/awaiter.ts:10:47)
    at main (/Users/akka/dev/electronapps/irccloud-desktop/node_modules/electron-builder/src/install-app-deps.ts:23:3)
    at Object.<anonymous> (/Users/akka/dev/electronapps/irccloud-desktop/node_modules/electron-builder/src/install-app-deps.ts:35:7)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)
    at Module.runMain (module.js:575:10)
    at run (bootstrap_node.js:352:7)
    at startup (bootstrap_node.js:144:9)
    at bootstrap_node.js:467:3

Use electron connection state API's to disconnect/reconnect

Command not found: install-app-deps

> [email protected] postinstall /home/charles/.npm-packages/lib/node_modules/irccloud-desktop
> install-app-deps

sh: install-app-deps: command not found
npm ERR! Linux 4.4.5-1-ARCH
npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "install" "-g"
npm ERR! node v5.10.1
npm ERR! npm  v3.8.6
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn

npm ERR! [email protected] postinstall: `install-app-deps`
npm ERR! spawn ENOENT
npm ERR! 
npm ERR! Failed at the [email protected] postinstall script 'install-app-deps'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the irccloud-desktop package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     install-app-deps
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs irccloud-desktop
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls irccloud-desktop
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/charles/builds/irccloud-desktop/npm-debug.log

Figure out automatic-upgrade process

Electron supposedly provides this, but I've seen other electron apps in the OSX app store. Not sure.

Remember window position

Needs to work with multiple monitors.

No right-click menu for copy/paste

Disable billing for MAS

Because it'll break app store requirements otherwise.

Windows installing progress image

32-bit Windows is not supported

log.txt

Good evening,

Here a little issue while installing the application which stopped the installation

Minimize to system tray (windows)

I was wondering if we can have the ability to minimize to system tray so we can have it out of the way but still get notifications.

Better user-style.css management

Add a menu item to edit the CSS file in a prompt, and/or reveal/open in OS.

Some shortcuts not working

cmd-[
cmd-]

Enterprise support

Add a menu item to provide an enterprise version hostname.

Clicking 'Help → Keyboard Shortcuts' doesn't do anything

I'm assuming that you folks probably forgot to add the JS code needed, or there is a legitimate bug in the software.

OS: Windows 10 Pro x64
Packaged version: 0.1.6 (you folks should probably add a spot under the help menu to show this)

Email feedback/logs/screenshot feature

Make the .dmg icon different from the app icon

It comes through a bit confusing at the moment, because the .dmg is called IRCCloud and has the same icon as the app. I think it would be less confusing to lose the .dmg icon entirely and have the default icon.

Icon broken in Linux

This commit: f30cfdb seems to have broken the icon in Linux.

I have a patch ready to submit a PR as soon as Github is done fixing the database issues they are having that are preventing me from opening a PR.

Spellchecking in input boxes

electron/electron#942

Mixed HTTPS and HTTP content prevent loading HTTP images

Unlink irccloud.com, HTTP links can not be embedded when irccloud.com is served over HTTPS to electron and those links are to HTTP resources.

I've found two options, include the Content-Security-Policy-Report-Only header in server responses as described here: https://developers.google.com/web/fundamentals/security/prevent-mixed-content/fixing-mixed-content?hl=en
Just disable web-security features 🍤 (originating issue: electron/electron#2076)

I would be happy to implement 2), as it's dead simple to do, but I feel like more security minded individuals should asses that decision.

Unable to right click/copy links

Right click appears to be disabled for some reason

Switch to NSIS for Windows

https://github.com/electron-userland/electron-builder/wiki/NSIS

Use electron mouse monitoring to detect machine in use

Missing page zoom

Possibly fixable with webFrame.setZoomLevelLimits(1, 10) see atom/atom#9216

Use a custom login/signup screen

We can probably assume that if a user has downloaded the app, they know vaguely what IRCCloud is, so it would be nice to show a simpler, more "app"-looking login/signup screen on first load, rather than the IRCCloud home page.

Support Electron 1.1.1

Currently this is broken on Electron 1.1.1 (latest).

I have a PR ready to submit shortly as soon as Github status issues are fixed.

Heartbeat from another client doesn't update the dock badge count

Marked a channel as read on mobile, dock icon badge still displays "1"

Option to disable or configure spellchecking plugin

As reported by some users the spellcheck plugin causes a UX problem when people speak other languages. I think it would be a good idea to customize or disable the spellchecking plugin to fix this.

OS X Code Signing

The OS X app should be signed by our Mac developer key.

Closing the window does not exit the app

Excessive white space on context click (Windows)

Running the latest version of the IRCCloud Desktop client (0.3.0)

Opening the context menu by either using the right click on a mouse or the appropriate key on the keyboard shows a menu that appears to be missing multiple items. Example is attached.

I am able to reproduce this issue on multiple machines but not on different operating systems as none are available.

Don't embed nsfw images

Hi,
Is there a feature that stops embedding images, tweets etc that has nsfw on the same line?

Some Electron branding still visible

"Electron" flashes in the title bar as the app starts, and the process list has Electron in it.

We'll need to build our own version from source to change this, it's not too tricky though.

Uncaught EPERM when resizing the window

Running version 0.1.7 on Win10 (10586.420) on x64, I sometimes see the following uncaught exception immediately after resizing the window:

[Window Title]
Error

[Main Instruction]
A JavaScript error occurred in the main process

[Content]
Uncaught Exception:
Error: EPERM: operation not permitted, rename 'C:\Users\rcshe\.config\configstore\IRCCloud.json.677343039' -> 'C:\Users\rcshe\.config\configstore\IRCCloud.json'
    at Error (native)
    at Object.fs.renameSync (fs.js:729:18)
    at Function.writeFileSync [as sync] (C:\Users\rcshe\AppData\Local\IRCCloud\app-0.1.7\resources\app.asar\node_modules\write-file-atomic\index.js:39:8)
    at Object.create.all.set (C:\Users\rcshe\AppData\Local\IRCCloud\app-0.1.7\resources\app.asar\node_modules\configstore\index.js:63:21)
    at Object.Configstore.set (C:\Users\rcshe\AppData\Local\IRCCloud\app-0.1.7\resources\app.asar\node_modules\configstore\index.js:94:11)
    at BrowserWindow.<anonymous> (C:\Users\rcshe\AppData\Local\IRCCloud\app-0.1.7\resources\app.asar\main.js:93:12)
    at emitOne (events.js:90:13)
    at BrowserWindow.emit (events.js:182:7)

[OK]

After I dismiss the dialog box, the application appears to continue working normally. In particular, the attempt to resize the window succeeds.

Figure out linux build

Dock icon/menu enhancements

Menus
macOS: http://electron.atom.io/docs/all/#custom-dock-menu-macos
Windows: http://electron.atom.io/docs/all/#user-tasks-windows
Unity: http://electron.atom.io/docs/all/#unity-launcher-shortcuts-linux

Progress bar (for file uploads): http://electron.atom.io/docs/all/#progress-bar-in-taskbar-windows-macos-unity
Windows icon badging: http://electron.atom.io/docs/all/#icon-overlays-in-taskbar-windows

Disable auto-updater for MAS/dev builds

Don't quit on window close (macOS)

It's not standard behaviour on macOS to quit the app when the last window is closed.

Annoying Notifications

I really cant stand the notifications my IRCCloud app makes. I mean, i do want notifications, but not in the middle of my screen. Is this something I can control?

Ctrl/cmd/middle click on links should keep focus in app

Blocked on electron/electron#4760

MAS/non-MAS dual code signing

Blocked on electron-userland/electron-builder#560, for the ability to specify two separate code signing certificates for different targets.

Error on startup on Linux

Uncaught Exception:
TypeError: Error processing argument at index 0, conversion failure from /opt/IRCCloud/resources/app.asar/icon.ico
at TypeError (native)
at setupTray (/opt/IRCCloud/resources/app.asar/main.js:179:13)
at EventEmitter. (/opt/IRCCloud/resources/app.asar/main.js:200:7)
at emitOne (events.js:95:20)
at EventEmitter.emit (events.js:182:7)

Keep app running in background, even if main window closes

Opening this in favour of #54

Intercept close events and hide the window instead.

Needs to show again when clicked in dock
Needs to NOT show again when cmd-tabbed to
Needs a Window menu item to show again, cmd-0
Needs to not quit on window close (might happen for free if we suppress close events)
TODO check/define Windows/Linux behaviour

Clicking a notification on Windows 10 doesn't focus the app

Blocked on electron/electron#2867