Giter VIP home page Giter VIP logo

Comments (7)

rjcausarano avatar rjcausarano commented on September 16, 2024

In order to fully support Galactic we need a few packages to be officially released. I also noticed that to support Galactic our source code needed a few modifications.

The good news is that these packages can be installed from source and there now exists a PR to address the compatibility changes: #53

To run create3 in Galactic please checkout to the above branch and then install the prerequisites from source: https://github.com/iRobotSTEM/create3_sim/blob/7d8e442ba4f765492df050306882d692042504fd/README.md

from create3_sim.

rjcausarano avatar rjcausarano commented on September 16, 2024

@eborghi10 @apojomovsky @LolaSegura @lchico @justinIRBT

from create3_sim.

eborghi10 avatar eborghi10 commented on September 16, 2024

@rjcausarano Next time, please create the galactic branch with the same changes as in master and, after that, a PR so we can review the changes.

I have a few questions:

  1. Can those changes be applied to Foxy?
  2. Rename the branch to galactic-devel.
  3. We should have a foxy-devel branch too.
  4. We have to define whether we want to keep master or remove it.
  5. The changes need to have a .repos file with ros2_control.

from create3_sim.

justinIRBT avatar justinIRBT commented on September 16, 2024

We might want to make a working galactic branch be master and have a foxy branch with the stuff that currently works with foxy

from create3_sim.

rjcausarano avatar rjcausarano commented on September 16, 2024

@rjcausarano Next time, please create the galactic branch with the same changes as in master and, after that, a PR so we can review the changes.

I have a few questions:

  1. Can those changes be applied to Foxy?
  2. Rename the branch to galactic-devel.
  3. We should have a foxy-devel branch too.
  4. We have to define whether we want to keep master or remove it.
  5. The changes need to have a .repos file with ros2_control.
  • This branch can't be merged with master because it will break foxy, there were breaking changes introduced in galactic
  • I also didn't want to make this branch master because as stated above... it requires building 3 packages from source. But this is only temporary until these are released

from create3_sim.

rjcausarano avatar rjcausarano commented on September 16, 2024

@eborghi10 PR created

from create3_sim.

alsora avatar alsora commented on September 16, 2024

We might want to make a working galactic branch be master and have a foxy branch with the stuff that currently works with foxy

I think it would be better to keep master as a separate branch from the release ones.

So we would have:

  • foxy
  • galactic
  • master

Developement can happen on master. Then changes can be backported from master to galactic if they are worth (e.g. critical bug fixes or non API/ABI breaking changes). When a new release comes out, we should branch from master.

Note that if we want to be fancy, the master branch should acutally target the ROS 2 rolling release (which is kind of a weekly released master)

from create3_sim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.