iron-fish / website Goto Github PK

Hi,

The page:
https://ironfish.network/docs/onboarding/send-receive-iron-fish-transactions

Says:
"E.g. To send 2 coins from the account Savings"
"ironfish accounts:pay -a 1 -o 0.00000001 -t 997c...7fc52ed -f Savings"

But the provided amount (-a 1) is not 2 counts, but 1. So there is a mismatch between description and executed command

My balance was: $IRON 0.00999999 but when i tried to burn is says I have no IRON to pay comission.

You are about to burn:
205d981e7e6a62b090c817e74b08e24d8bbe5075428221e7cd76240db5022056 0.00001500 plus a transaction fee of $IRON 0.00000001 with the account cryptoartemiy01
* This action is NOT reversible *
Do you confirm (Y/N)?: Y
Creating the transaction: [████████████████████████████████████████] 100% | ETA: 0s
An error occurred while burning the asset.
 ›   Error: Request failed (400) error: Insufficient funds: Needed $IRON 0.00000001 but 
 ›   have 0.00000000 available to spend. Please fund your account and/or wait for any 
 ›   pending transactions to be confirmed.'
root@vm905564:~# ironfish wallet:balanceAccount: cryptoartemiy01
Balance: $IRON 0.00999999

when searching by Graffiti, the style is not friendly to look, especially rank is too high.

Found a few typos in this article on your website titled "We take privacy features to a whole new level" that can make it a bit tough to read

Ethereum Smart Contract section:
The bigger flaw however, is that these protocols suffer from being built on top of a fundamentally transparent system where deposits and withdraws {withdrawals} must be made public.

Monero section:
Researchers have criticized decoys for privacy guarantees and numerous research and papers {research papers} have since come out further exploring Monero vulnerabilities (such as this one and this one). Monero vulnerabilities go past being just theoretical —CipherTrace claims to have de-anonymized Monero transactions and {the} IRS gave away over $1M in grants to Chainalysis and Integra FCC to further provide de-anonymization tools for Monero.

Mobilecoin section:
Mobilecoin {is} a privacy coin that took {takes} Mobero’s {Monero’s} privacy technique and relies on SGX technology to provide mobile support.

Zcash section:
The Sapling protocol utilizing Zero-Knowledge Proofs (specifically zk-SNARKs) has the highest privacy guarantees when compared to all other privacy techniques. This protocol allows transactions to have all sensitive data encrypted and completely unlikable {unlinkable}.

What happened?

Hello! I want to report a small mistake on your website.
On a «Roadmap» page at the end it is written:
Click here to get started with running an Iron Fish node, check out our github for open source contributions.
Both links redirect to the same GitHub page, while the first link should redirect to «Mine Iron Fish» page. Thank you!

Version

No response

Relevant log output

No response

The login button in the navbar becomes hidden between the md (768px) and lg (1024px) breakpoints.

I tried to fix this in Navbar/index.js but don't know enough about Tailwind. Seems like the quickest fix would be

// line 92
- <div className="hidden md:flex items-center lg:text-xl">
+ <div className="hidden lg:flex items-center lg:text-xl">

// line 99
- className={`md:hidden ${overrides.button} ${overrides.menuButton}`}
+ className={`lg:hidden ${overrides.button} ${overrides.menuButton}`}

Unfortunately, that doesn't seem to work. In tailwind.config.js I see that both md and lg are commented out, but I'm not sure if that has anything to do with it, and that's as far as I was able to get.

There are several typos currently found in the website e.g, there are misspelled words, repeated words, redundant words, misplaced words, missed words, misplaced punctuations, missed punctuations, incorrect word usage, and extra white spaces.

There are many such incidences of each and I'll fix most of them, but to save space, here are a few of them:

Misspelled words

Do not use a production bootstrap node that isn't offically endorsed by Iron Fish, you might end up on a malicious network.

Repeated words

It is the miner’s job however to make sure that that Merkle root is one that is associated with a valid tree.

Redundant words

You can use the Iron Fish Block Explorer to display information about this transaction. Of course, because Iron Fish is a fully private cryptocurrency, a limited amount of information is actually available to the public.

Misplaced words

And finally, that after all the transactions are added to the two global Merkle Trees of Notes and Nullifiers

Missed words

The Mining section describes how new blocks are constructed containing the necessary randomness for proof of work (PoW), as well the miners reward calculation.

Missed punctuations:

Node A broadcasts to Nodes B, C, D and E.

Incorrect word usage

You can read about the different accounts commands on this section.

Extra white spaces

At Iron Fish, we are building something we\’re truly proud of: a cryptocurrency that does not compromise on privacy or accessibility. Digital cash that embodies using privacy for good. We <- Github corrects the whitespace by default

A PR needs to fix these issues in the whole website, rather than when they are noticed. To do this I can triple-check the whole website for typos. Then triple-check the changes according to context. This might take time, but it is going to be worth it.

A small text alignment issue that I found. The text "Thank you for subscribing!" should be aligned in the center, which would look better.

Will work on this if accepted.

So everywhere ironfish logo is located, whether it be on the blockchain explorer, or other places, it redirects us to the ironfish website inside the same tab. But not the one in the footer of the main ironfish website. So this opens it up in a new tab, which really isn't needed when we're already on the main website. This is also inconsistent with all the other links on the ironfish website which do not open in a new tab.

A fix I'm going to work on is, to not open the ironfish website in a new tab, but just redirect to the home page of the ironfish website.

If you guys instead think that opening the ironfish website in the new tab, is good for the logo in the footer, and basically it's good as it is. Then this functionality should also be reflected in the footer of the blockchain explorer website as well.

Below is an image of the footer with the logo:

I found a few documentation issues in the installation page, found under get started page on the ironfish website. Just some spelling and grammar fixes. There are three spelling and grammar issues, which I have pasted below:

1. Here the text should read: update "them" through

2. "the" is repeated twice, the second one is unnecessary, and hence should be removed

3. Here it should be: from "the" source

The CLI webpage could use a documentation update.
The chain:show command's code takes start and stop parameters.

On smaller screens like a mobile phone, the blog posts heading text start to blend in with the photo. I can work on a fix for this

The site still contains information about mining rewards. Many people mistakenly assume that the information applies to phase three and continue to mine, creating questions as to why the rewards for this do not show up in the points.
https://ironfish.network/docs/onboarding/miner-iron-fish

When I follow the official guide to complete tasks - they do not count
e.g.
ironfish wallet:mint
3d9fe7d498db38418f3d98ce5a05825c196a7ddfe7f6dc12073b2dfb4a55fa2e - hash
But when I started following the one-line commands from the guides, the tasks were counted, for example
ironfish wallet:mint -a 1 -f Wallet-Iron-Fish-2001 -m Iron-Fish-2001 -n Iron-Fish-2001 -o 0.0000001 --confirm
da569a60da45bcee27841afb05baf040759424b30f0b48487e2273286319d248 - hash

Judging by the questions on the discord, many participants are experiencing a problem in tasks, could you comment on this?

Cripto

CLI docs saying there a ironfish config:show but its not there, kindly update the docs
https://ironfish.network/docs/onboarding/iron-fish-cli#config

however the command to show the whole config is ironfish config

ironfish 0.1.62
node 18.13

Add a new category named application in ecosystem page

We needed to have Twitter pick up our blog images correctly, which requires full paths including the domain.

I am missing how to make docusaurus do this, so I took a shortcut, market with this ticket ID.

Find the "right" way

On account creation page, the section

The Authorization Key (ak) is derived as the public key for the spend authorization key by multiplying the spend authorizing key with a fixed generator base point for it on the Jubjub curve.

links to a google doc that requires permission to access

a whitepaper in pdf is necessary together with the tokenomics to appreciate the project without clicking to turn the page on the official site

Please, add lolMiner as miner. It is the faster and the one to develop the last increase hashrate.

Many thanks in advance

It would be nice to have additional information describing how to mint a new asset vs minting an existing asset. It's not very obvious that in order to mint a new asset, assetId (as part of the wallet/mintAsset request) should be null. It would be nice to have descriptions of each request parameter as bullet points (example). Within the assetId param description, it should be noted that in order to mint a new asset, assetId should be null.