ironhack-labs / lab-javascript-functions-and-arrays Goto Github PK

Currently, two additional bonus iterations are placed as sub-iterations so if students would follow the steps as they come, they could spend a lot of time on the bonus sub-iteration 3.1 and not finish the iteration 4.
Solution:

• separate/move bonus iterations at the end of the lab.

Under "Bonus - Iteration #3.2: A generic sum() function" in the Readme, the result is 57 but in the actual test, the result is 56.

1. Review greatestProduct(matrix) needs a better test since it is passing with some wrong implementations

2. Create test(s) for greatestProductOfDiagonals(matrix)

Hey guys,

It seems that the tests have recently changed from sumArray to sumNumbers, but the README file still refers to sumArray.

Thanks.

JOC

Under Iteration 3.2 Bonus the test requires us to throw an error if the typeof data is not allow. After implementing it, I realized that you have to literally write the exact sentence included in the test, otherwise the test won´t pass, even though the function is throwing an error.
The thing is that nowhere else this is specified, creating confusion. I hope I´ve explained myself, thanks!

Missing test for bonus iteration 8.1.