Giter VIP home page Giter VIP logo

ansible-role-proxmox-nag-removal's Introduction

Hey ๐Ÿ‘‹, I'm Alex AKA IronicBadger

Father. Podcaster - @selfhostedshow. Photographer. Tinkerer. Tailscalar.

Linkedin Mastodon Matrix Twitter Reddit

๐Ÿ“บ Latest YouTube Videos

Hardware VLOG | Upgrading the Perfect Media Server with an Intel i5-13600k and Supermicro X13-SAE-F Hardware Vlog | Friday night building servers with Alex! Alex rewires his rack with a Unifi PDU Pro, an 8 port HDMI PiKVM switch and installs new hard drives An Epyc Homelab Monster: the Perfect Media Server mega upgrade My Perfect Media Server isn't so perfect anymore... An Unbiased Comparison of the Prusa MK3 vs Bambu Lab X1-Carbon

๐Ÿ“Š Stats

ansible-role-proxmox-nag-removal's People

Contributors

alex-phillips avatar aroberts avatar ironicbadger avatar jsclayton avatar katanacrimson avatar mattburchett avatar pagdot avatar ronbosworth avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

ansible-role-proxmox-nag-removal's Issues

"New" way of removing the nag screen.

Per johnscs.com:

  tasks:
    - name: Silence the Proxmox subscription nag
      ansible.builtin.blockinfile:
        path: /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js
        insertafter: 'checked_command: function\(orig_cmd\) {$'
        block: |
          {% filter indent(width=8, first=true) %}
          orig_cmd();
          return;
          {% endfilter %}
        marker: "\t// {mark} Ansible managed block"
        backup: true
      notify: Restart Proxmox

  handlers:
    - name: Restart Proxmox
      ansible.builtin.systemd:
        name: pveproxy
        state: restarted

Tested on 8.2.2

Role is not idempotent

I'm new to ansible so perhaps I'm not doing things the Right Way, but it would be great if the tasks in remove-nag.yml were idempotent and did not create an additional backup file each time they were run.

[Discussion/Suggestion] Better alternative instead of sed to change files

ansible.builtin.shell + sed is a little bit a hack when using ansible.

A better way would be to use ansible.builtin.replace because it should be similar to sed, but included in ansible and would properly report if there were changes.

An alternative way, brought up by @FuzzyMistborn on Discord would be to use a diff file and patch like discussed here: foundObjects/pve-nag-buster#3

This would make it easier to work with (no hard-to-read regex), but I haven't seen an ansible module to patch a file. This would require Copying the diff and then executing patch.

I'm willing to add a patch to implement either of the two in a PR :)

I'd like to wait for the completion of #8 first to prevent issues or doing it twice (Didn't see that is was already accepted)

Proxmox 8 Support

First, thanks for putting this together as well your infra repo! It's a great reference when IaCing my home lab.

I just tried installing this role on a new Proxmox 8 box. It looks like Proxmox 8 includes a new source for ceph which also needs to be updated. The add-no-subscription repo task fails because the ceph.list (newly added in 8 maybe?) is pointed at the enterprise repo. I manually updated this to deb http://download.proxmox.com/debian/ceph-quincy bookworm no-subscription and the task ran successfully adding the pve-no-subscription repo as expected.

The nag message tweak appears to be broken.

If you like I can try to put together the changes while trying to maintain backwards compatibility and submit a PR.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.