Giter VIP home page Giter VIP logo

crackbookrevival's People

Contributors

admp avatar gintas avatar ishmaeel avatar jamuspsi avatar jasu avatar nickwb avatar prettymuchbryce avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

crackbookrevival's Issues

New URLs within the same domain are also blocked

First of all, thanks for the good work of reviving this very useful chrome extension.

I am having the following issue: whenever I open a new tab from a junk site (e.g. http://facebook.com) or when I access another URL within the same domain (e.g. http://facebook.com/myprofile) the delay is applied once again.

I don't know if it is intended, but what I think would be the best solution in this case is the delay should not be applied as long as we have at least one open tab of the respective junk site.

Then, if at some point all tabs of the junk site were closed, the next time we open one the delay should be applied again.

Does this make sense?
Thanks for your attention and support.


Edit: Another extension named Delayed Gratification has a functionality that addresses this problem of blocking new tabs: it is possible to set up a timer that only blocks new open junk sites after a configured interval. This let's you access the junk site and keep opening new tabs freely for a while.

bug: `watchUrlChanges` does not check that the new path is still a junk domain

There is code in dimmer.js which watches the URL for changes, watchUrlChanges, allowing the dimmer to be re-triggered when navigating within a SPA. Unfortunately, this code assumes that the page is still in the junk list. This may not be true, particularly if you have a path in your junk domain.

An example scenario:

  • You have youtube.com/watch in your junk list
  • You watch a video on youtube, triggering the dimmer
  • You click on a button to some other youtube feature which is not on the junk list (e.g., home, or your subscription list, etc.)
  • The dimmer is re-triggered, even though the current URL is not considered junk

I'm planning on opening a PR to address this later in the week.

UX / UI Support

Hello - I am a Product Designer hopeful that is looking to offer UX support / redesign for the Settings / Statistics menus on spec. Without a way to send private messages I thought this would be the most appropriate place to start a conversation. Thoughts?

Feature request: whitelist

I think it would be useful if, rather than timing out individual sites and allowing the rest of the internet through, we could tick a box to block everything except for some specified sites. There are way too many distracting sites out there to catch all of them, but there's a pretty much finite number of non-distracting sites.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.