istador / old-search-fixed Goto Github PK

The Search Bar Icon isn't updated, if the default search icon is changed somewhere else.
E.g.:

• Right click context menu: "Set As Default Search Engine"
• Search browser settings

Test out this add-on with older Firefox versions and other forks to find out what the minimum supported version is exactly, so that the intall.rdf can be updated accordingly.

Currently I only tested:

• Waterfox 56.2.3 for Windows 64-bit
• Firefox 56.0 for Linux 32-bit (56.0+build6-0ubuntu1 i386)
• Firefox 56.? for Linux 64-bit (?)
• Firefox 62.0 for Windows 64-bit (manually with the BrowserConsole, not as an add-on)

This feature, either triggered by the right-click context menu or by pressing the middle mouse button, is currently not changing the default search engine.

Introduce a new user option to control the behavior of it.

I'm new to Waterfox and I use WaterfoxPortable_56.2.12_English.
I installed old-search-fixed 3.0.3 and in it's Options turned on "Search Bar" but I can't see it working.
When I click another engine to search, default remains the same.

This add-on can't be added to AMO because they won't sign nor accept legacy add-ons anymore. They will drop all XPI files from there servers in October 2018, causing problems for other Firefox forks that use AMO for extensions.

Likewise, Thunderbird's add-on page (ATN?) accepts legacy add-ons, but won't sign nor accept add-ons that are for Firefox and Thunderbird.

Hopefully, Waterfox's legacy extensions database (BrowserWorks/Waterfox#303) will someday allow signing and submitting new add-ons.

Palemoon is hosting their own add-on database and is open for submissions, but this add-on wouldn't enrich it in any way, because they forked away before Firefox 43 changed the Search Bar for the worse.

How is IceCat's and Bisilisk's stand on legacy add-ons and hosting them?

There should be a free and independent extensions database that targets all browsers.
How difficult would it by to host that or develop a distributed solution?

Another thing to improve the current situation at least for my add-on, would be for me to self-sign the XPI release files. I haven't come around to install NSS on Ubuntu or Debian yet.

Offer selectable styles for the Search Bar popup menu.

Example with userChrome.css:
https://www.jeffersonscher.com/gm/search-bar-names.html

(Problem: The same as in #3, but this might also be solvable by plain JavaScript manipulation, though not optimal.)

Currently, when a search engine is clicked on to select the default, the popup menu is closed.
For a better user experience, the popup should be left open.

The user should be able to change this behavior in the options (whether it should be open or closed after the click).

Technical:

The popup menu needs to be closed, because it's content isn't updated otherwise (the default search engine is displayed differently from the others, changing the default isn't updating the already opened popup menu).

When the popup menu is opened right after closing it, the click handler for the search engine is still executed and is trying to work on the old popup menu which results in an Error.

Maybe the popup's content can be updated manually, or the old popup can be hidden instead of closed, to prevent the Error.

By setting the Search Bar Icon manually via JavaScript the default browser behavior of it is overwritten:

• The magnifier icon is normally a bit transparent, on mouseOver it gets opaque.
• On mouseOver it also gets a little downward arrow to indicate the popup menu that can be opened.
• Being on a website that offers a search engine, a green (+) icon is shown.

These features should be available again when the Icon option of this extension is setted.

(Problem: How to introduce custom CSS rules for browser features beside from userChrome.css? Maybe inserting a <style> element in the browser's DOM?)

When this add-on is installed, and the browser is starting, the add-on exchanges the magnifier icon with an empty icon.

After changing the default search engine, or by disabling and enabling the Icon setting, it is working as intended.

The style for the element after starting the browser contains the following:

background-image: url("");

This indicated that the src attribute of BrowserSearch.searchBar isn't initialized properly yet when the add-on is loaded.

Possible solution:
Set the icon again after browser-delayed-startup-finished is triggered (currently the add-on prevents initializing the same window twice, so it is ignored for already initialized windows)

Also:
When BrowserSearch.searchBar is empty or it can't find an icon for a search engine otherwise (e.g. Services.search.defaultEngine.iconURI.asciiSpec), the add-on should fallback to the default browser's magnifier icon.