Comments (8)
I like the idea. I think the synchronous methods should be wrappers of the async methods, correct?
from harvest.net.
That's one way of doing it, but sometimes you can run into issues around the synchronization context. Further reading: http://blogs.msdn.com/b/pfxteam/archive/2012/04/13/10293638.aspx
My usual recommendation would be to refactor out the code as much as possible for re-use, but keep the sync/async call stacks separate. But, we could do ConfigureAwait(false) too if RestSharp doesn't deadlock from using it.
from harvest.net.
Here is my first pass at refactoring to support async, with just Account and Client methods done so far. Let me know if this is along the lines of something that you'd be okay with before I get too much farther.
from harvest.net.
Sorry for letting this drop.
Your approach looks fine by me.
from harvest.net.
Cool, working on this now.
from harvest.net.
���Hey @paulirwin I would like to know how is the Async thing going ?
from harvest.net.
@Willjobs94 Unfortunately I completely stopped work on it and forgot about it. Thanks for reminding me! My progress is here: https://github.com/paulirwin/harvest.net/tree/feature/async
If anyone wants to help me out that would be awesome.
from harvest.net.
PR #75 submitted today, 21 months later. Better late than never?
from harvest.net.
Related Issues (20)
- .ListProjects() returning null HOT 2
- NuGet package is not signed HOT 3
- Currency Updated HOT 1
- Currency field in Invoice HOT 10
- Update DailyOptions Model HOT 1
- Throw a HarvestException for any 4xx or 5xx HTTP status code HOT 2
- C# 6 support? HOT 2
- Getting Data in Postman, but not in c# Code HOT 8
- Add Resource methods to IHarvestRestClient to allow for Mocking of HarvestRestClient for testing. HOT 1
- AUD/USD Currency on getClients() HOT 4
- .net core support HOT 11
- .ListExpenses() returning empty list HOT 1
- .ListProjects() Returning null
- Creating payments using OAuth2 results in a 500 HOT 1
- Weekly Capacity not returned by ListUsers HOT 1
- Listing invoice with only "from" parameter returns incorrect results HOT 1
- project.ListTaskAssignments returns null
- supporting Harvest API V2 HOT 11
- .ListContacts returning null
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from harvest.net.