Giter VIP home page Giter VIP logo

Comments (8)

ithielnor avatar ithielnor commented on August 17, 2024

I like the idea. I think the synchronous methods should be wrappers of the async methods, correct?

from harvest.net.

paulirwin avatar paulirwin commented on August 17, 2024

That's one way of doing it, but sometimes you can run into issues around the synchronization context. Further reading: http://blogs.msdn.com/b/pfxteam/archive/2012/04/13/10293638.aspx

My usual recommendation would be to refactor out the code as much as possible for re-use, but keep the sync/async call stacks separate. But, we could do ConfigureAwait(false) too if RestSharp doesn't deadlock from using it.

from harvest.net.

paulirwin avatar paulirwin commented on August 17, 2024

Here is my first pass at refactoring to support async, with just Account and Client methods done so far. Let me know if this is along the lines of something that you'd be okay with before I get too much farther.

paulirwin@de2e28a

from harvest.net.

ithielnor avatar ithielnor commented on August 17, 2024

Sorry for letting this drop.

Your approach looks fine by me.

from harvest.net.

paulirwin avatar paulirwin commented on August 17, 2024

Cool, working on this now.

from harvest.net.

Willjobs94 avatar Willjobs94 commented on August 17, 2024

���Hey @paulirwin I would like to know how is the Async thing going ?

from harvest.net.

paulirwin avatar paulirwin commented on August 17, 2024

@Willjobs94 Unfortunately I completely stopped work on it and forgot about it. Thanks for reminding me! My progress is here: https://github.com/paulirwin/harvest.net/tree/feature/async

If anyone wants to help me out that would be awesome.

from harvest.net.

paulirwin avatar paulirwin commented on August 17, 2024

PR #75 submitted today, 21 months later. Better late than never?

from harvest.net.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.