Giter VIP home page Giter VIP logo

Comments (11)

paulirwin avatar paulirwin commented on August 17, 2024 2

At this point, I'd consider your port to .NET Standard to be 2.0, and any future refactorings/rewrites to be 3.0+. "Perfect is the enemy of the good" and all.

from harvest.net.

lprichar avatar lprichar commented on August 17, 2024 1

I just converted it to .Net Standard 2.0 for my personal project. The unit tests all pass, but I don't know if it's worth making a PR for or not because I had to convert the visual basic TextFieldParser to a CvsHelper project I found in Nuget and I don't use that functionality, so I can't guarantee I did it correctly. It's here if anyone wants it: https://github.com/lprichar/harvest.net and I'm happy to make a PR if the authors would like.

from harvest.net.

paulirwin avatar paulirwin commented on August 17, 2024 1

@lprichar Awesome, this is only possible now because RestSharp now supports .NET Standard 2.0. It didn't at the time that I started a rather ambitious rewrite. I'd still like to continue down that path but it's of less importance now. Please create a PR, I'd like to review and help test.

from harvest.net.

ithielnor avatar ithielnor commented on August 17, 2024

Perhaps as part of 2.0. Haven't really looked into it.

from harvest.net.

asoet avatar asoet commented on August 17, 2024

Okay thanks.
Do you have a roadmap?

from harvest.net.

ithielnor avatar ithielnor commented on August 17, 2024

Just what's tracked here: https://github.com/ithielnor/harvest.net/milestone/2

from harvest.net.

paulirwin avatar paulirwin commented on August 17, 2024

I'll gladly take this one once #75 is confirmed good to go and merged in.

from harvest.net.

kfrancis avatar kfrancis commented on August 17, 2024

Refit is a good replacement for restsharp, if it still doesn't support net core.

from harvest.net.

ithielnor avatar ithielnor commented on August 17, 2024

@lprichar Looks cool. Can you submit a PR to 2.0?

from harvest.net.

paulirwin avatar paulirwin commented on August 17, 2024

@lprichar Can you make a PR for this? I've successfully tested it and at least for my use it works well.

from harvest.net.

lprichar avatar lprichar commented on August 17, 2024

I'm happy to PR it against master, but redoing it for 2.0 would be non-trivial. I guess I'll just do that, and then the maintainers (@ithielnor) can reject it, and I won't be mortally offended.

from harvest.net.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.