itsmebriand / percival Goto Github PK

As far as I can tell the files in ´Views/Launch/´ don’t follow a strict Model View Controller (MVC) pattern.

It’s loading data (task of a controller), storing it in a global variable ajaxRequests (the model) and writing it into the DOM (task of a view). This all happens in one file and the MVC components are not split into different files or marked by inline comments.

While this is a valid practice, the view code is not clearly separated in M, V, and C.
Furthermore, MVC wants data binding. This requires that the view observes the model for changes and updates itself when new data becomes available.

I see that you mainly regard the backend code to follow the MVC pattern. Is your front end code deliberately exempt from this?

https://github.com/0c370t/Percival/blob/d71d260e780f7b7396a2a93ea7f8c7518a57db55/Views/Shared/_Layout.cshtml#L30-L32

You chose to prevent users from reloading the Home page by clicking on the header.
While you documented what this code does, it would be valuable to know why the decision was made.
I don’t understand why the functionality of the header should differ on the Home page, if users are not losing any input data because of this.