The simple-dialog from itsmejithin

Copy to clipboard only works in onCancel not onSucces

Hi,
and thank you very much for simpleDialog.js.

I'm using it to popup messages from my Ajax operation success/failure.

In case of failure, I offer the user an option to copy the error message to clipboard.

For some reason (I'm not a Javascript/JQuery expert), the error text is only copied to clipboard in the
first example.

This works:

    <script type="text/javascript">
        $(document).ready(function () {
        $.simpleDialog({
        title:"<?php echo PHPLIST_REST_API_SUBSCRIPTION_HEADER_ERROR?>",
        message:"<?php echo PHPLIST_REST_API_SUBSCRIPTION_TEXT_ERROR.$result?>",
        confirmBtnText:"<?php echo PHPLIST_CLOSE_BUTTON?>",
        closeBtnText:"<?php echo PHPLIST_COPY_BUTTON?>",
        onCancel:function(){
            var text = "phpList Rest API\n";
            var email =  "<?php echo PHPLIST_REST_API_SUBSCRIPTION_EMAIL_TEXT.$subscriberEmail.'\n'?>";
            var error_text = "<?php echo $result .'\n'.$time.'\n'.$ip?>";
            var dummy = document.createElement("textarea");
            document.body.appendChild(dummy);
            dummy.value = text + email + error_text;
            dummy.select();
            document.execCommand("copy");
            document.body.removeChild(dummy);
            alert("<?php echo PHPLIST_CLIPBOARD_COPIED_TEXT;?>");
        }
    });
    });

</script>

This doesnt work (the clipboard contents remain unchanged):

    <script type="text/javascript">
        $(document).ready(function () {
        $.simpleDialog({
        title:"<?php echo PHPLIST_REST_API_SUBSCRIPTION_HEADER_ERROR?>",
        message:"<?php echo PHPLIST_REST_API_SUBSCRIPTION_TEXT_ERROR.$result?>",
        closeBtnText:"<?php echo PHPLIST_CLOSE_BUTTON?>",
        confirmBtnText:"<?php echo PHPLIST_COPY_BUTTON?>",
        onSuccess:function(){
            var text = "phpList Rest API\n";
            var email =  "<?php echo PHPLIST_REST_API_SUBSCRIPTION_EMAIL_TEXT.$subscriberEmail.'\n'?>";
            var error_text = "<?php echo $result .'\n'.$time.'\n'.$ip?>";
            var dummy = document.createElement("textarea");
            document.body.appendChild(dummy);
            dummy.value = text + email + error_text;
            dummy.select();
            document.execCommand("copy");
            document.body.removeChild(dummy);
            alert("<?php echo PHPLIST_CLIPBOARD_COPIED_TEXT;?>");
        }
    });
    });

</script>

When debugging, I noticed that dummy.selectectionStart and dummy.selectionEnd both point to the end of dummy.value.

I suspect that the reason is timing related (probably setTimeout in simpleDialogjs).

If I set a breakpoint on the line "dummy.select()" and immeadiately continue, it works.

Any ideas for a fix? Or, should I just use the onCancel alternative?

itsmejithin / simple-dialog Goto Github PK

simple-dialog's People

Contributors

Stargazers

Watchers

Forkers

simple-dialog's Issues

Error handling response: TypeError: $(...).modal is not a function

Copy to clipboard only works in onCancel not onSucces

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent