ivanderjmw / pe Goto Github PK

Bug

When given duplicate arguments, the program will parse as if nothing is wrong.

Steps to reproduce

1. Enter profile menu.
2. Delete any profile that exists using delete.
3. Input the following: add /n Name /n Name 2 /h 182 /w 90 /e 120 /c 0

Expected output

Prompts the user to reenter because there is an error

Screenshot

Bug

If a user specifies an argument more than once, the program will take it as a valid input.

Steps to reproduce

1. Enter workout to enter workout session.
2. Create a new session using new.
3. Input the following, add Pushups /n 20 /w 8 /n 90 /w 20, or something similar.
4. The program will proceed with no errors.

Expected output

Prompt the user to enter a valid input.

Screenshots

Bug

Exception in thread "main", no line found.

Steps to reproduce

After running the .jar file, press Ctrl + D.

Expected outcome

The program will end without exception.

Screenshots

Implementation sections might be too detailed. It explains how the code works but does not explain why it works.

Developers should be more interested on why you chose the implementations. (It is nice that you indicated this at the end of every implementation section).

A minor typo in NewWS is also present.

There might be a problem in this alt block. If the specified condition is true, then the DietSessionSearch object will return commandResult twice. Is that intended?

Bug

Losing a diet session data

Steps to recreate

1. Enter the diet session.
2. Create a Diet Session using new.
3. Add a food in that diet session, e.g. add food /c 20000.
4. Exit that session using exit.
5. List the diet sessions with list.
6. Create a new diet session with new.
7. Type an invalid command, e.g. exit.
8. Enter end.
9. View the list again. Your last created diet session is gone.
   Shown as attached in the screenshots. Sorry for long post.

Expected output

User data should be preserved.

Screenshots.

No details provided.

Bug

A thrown exception: java.util.NoSuchElementException: No value present.

Steps to reproduce

1. Open diet menu.
2. Create a new diet session by using new.
3. Try to search by entering search something.
4. Program will return the indicated exception.

Expected

Either search returns no results, or prompts the user to add a diet session.

Screenshots

• The classes are missing semicolons :. They should be :Duke, :CommonUI, and etc.

• A missing actuation bar between CommonUi and Duke seems to break the consistency of the diagram.

• The user does not seem to receive a feedback from the program in this diagram.

Is Command an abstract class? It would be nicer to exlude abstract classes in sequence diagrams.

Bug

Date formatting is mixed, between dd-MM-yyyy and DD-MM-YYYY

Details

Inside diet menu, the new command uses yyyy-MM-dd, while the search command uses DD-MM-YYYY.

Expected

Both date formats should be identical to ease the user.

Screenshot

The methods are not written in the correct format.

It should have been in this format: +/- methodName(signature): returnType

Based on the descriptions, it seems like CommonUi has static methods. Maybe you could underline the methods to indicate it as static, also if it is a static class.

Class names are not prefaced with a semicolon.

Bug

An invalid search argument might show a co

Some of these words might be new for a developer, and you might need to give a reference to the definition.

• JUnit test
• Gradle
• Gson
• Apache Commons
• IntelliJ