Giter VIP home page Giter VIP logo

kirbycms-redirects's People

Contributors

amustill avatar iv-craig avatar ivi-admin avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

kirbycms-redirects's Issues

Support for get params

Get params seems to be unsupported at the moment. In the $uri var in function redirecty() (redirecty.php) get vars are stripped out.

So right now it is not possible to have rules like:

/news.php?id=1 => /news/my-first-item 
/news.php?id=2 => /news/my-second-item 
/news.php?id=3 => /news/my-third-item 

Edit redirects page gives an error

Hey,

The panel admin seems to be fixed now. However, when I click edit on the redirects page, I get a 404 error:

Page not found: http://localhost:8888/panel/pages/redirects/edit

The problem is because I'm running my blog in a subfolder on a local machine.

Also, if I go to http://localhost:8888/blog/panel/pages/redirects/edit, I get the following error:

The page could not be found

Also, it doesn't seem that a blueprint redirects would be created automatically - should I create it manually?

Redirection does not work correctly for multilanguage setups

Multilanguage sites currently do not redirect to the correct language when pages have versions in multiple languages.

  • Added: dev branch has an additional check for the detected language and prepends the language's URL as defined in the config file.
  • To do: Use a page's URL key to allow for redirection on more complex multilanguage setups

Problem with installing the plugin

Hey,

When I install the plugin in the site/plugins/redirecty I get the following error when I want to access the admin panel:

Whoops \ Exception \ ErrorException (E_ERROR) Method Kirby\Panel\View::__toString() must not throw an exception, caught Error: Call to a member function redirects() on boolean

Any idea how should I fix this?

Thanks

intercepting urls question

I've installed the plugin files/page/template/blueprint and function(). The rest of the site works fine, but the redirection I've added (inventory.html -> inventory) doesn't seem to be triggered.

I'm running this on a local php server, and I'm getting a standard php "The requested resource /inventory.html was not found on this server."

I suspect this problem is from my setup somewhere, so I'm curious if you have any suggestions to help? Thanks for any time you can spare.

Redirect immediately option?

Right now, kirby keeps running after the call to redirectty(). This means that if there is a redirect found, the old page is completely generated before the redirect takes place.

We discovered this because we had error logging set up on our error page and it would trigger even through there was a redirect in place (that worked). This caused some head scratching until I fired up a debugger.

One way to avoid this would be if the redirectty() function stopped processing on a redirect. I haven't read through the code to see if that's possible.

The other option would be to return true if redirectty caused a redirect to take place. We could then end processing at that point.

I'm curious as to your thoughts. If you'd rather I post this over in the kirby forums instead of here in an issue, I'm happy to do that.

Enough bitching.. Thanks for the plugin, it saved me from having to write my own!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.