Giter VIP home page Giter VIP logo

Comments (8)

ugurdogrusoz avatar ugurdogrusoz commented on May 17, 2024

@d2fong This shouldn't happen even if you turn off "fisheye" and "layout" (see the behavior in Newt for instance). How do you initialize the extension? Have you looked at the settings described here: https://docs.google.com/document/d/16EX9IBmJyYmPqxbCon-r4qE-5nDWl2SB6g9-nGApkO0/edit?usp=sharing

from cytoscape.js-expand-collapse.

d2fong avatar d2fong commented on May 17, 2024

@ugurdogrusoz @gbader

Yes I am following that document and using all of the settings you recommend for collapsing complexes by default.

from cytoscape.js-expand-collapse.

ugurdogrusoz avatar ugurdogrusoz commented on May 17, 2024

Since the nodes have not moved at all after expand, layoutBy must be null (default); can you please try setting it to cose-bilkent with randomize "false" and animate set to "end"? If that doesn't work, I suggest we hold a hangout sometime next week to go over your code and track the problem down.

from cytoscape.js-expand-collapse.

d2fong avatar d2fong commented on May 17, 2024

Are you sure it is not a problem with the extension?

from cytoscape.js-expand-collapse.

ugurdogrusoz avatar ugurdogrusoz commented on May 17, 2024

I am not claiming it's not a bug on our end; I am just trying to understand why we're not able to reproduce it on our end, with the settings suggested. Perhaps, you're setting animate to "during" instead of "end" since there is a known issue for this: cytoscape/cytoscape.js-cose-bilkent#47? This wouldn't explain why nodes wouldn't change locations at all (except the expanded node) upon expand since there should be an incremental layout running during expand. Can we please have a hangout where you show us the related code and we try to track it down on Monday? Are you available your afternoon?

from cytoscape.js-expand-collapse.

d2fong avatar d2fong commented on May 17, 2024

Okay good to know you couldn't reproduce it. I'll investigate more.

Thanks.

from cytoscape.js-expand-collapse.

d2fong avatar d2fong commented on May 17, 2024

Okay, I found the issues with my code:

  1. I wasn't using the latest version of the extension.
  2. I was using the expandcollapse.afterexpand event which I assumed was fired after the whole operation was complete, but it is actually fired before the expanded node children's positions are updated, which lead to the behaviour that I described in the github extension.

Thanks again for the support @ugurdogrusoz

from cytoscape.js-expand-collapse.

ugurdogrusoz avatar ugurdogrusoz commented on May 17, 2024

Great @d2fong I am glad it's solved

from cytoscape.js-expand-collapse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.