j-arens / wp-rest-router Goto Github PK

View Code? Open in Web Editor NEW

7.0 2.0 0.0 49 KB

WP Rest Router - bringing the developer experience of Laravel and Express to WP

PHP 95.04% Dockerfile 0.93% Shell 4.04%

wordpress wordpress-rest-api wordpress-router

wp-rest-router's People

Contributors

Stargazers

Watchers

wp-rest-router's Issues

Why converting Exceptions into WP_Error?

IIRC the WP_Error was a way implemented in WP time ago when Exceptions weren't a thing.

Wouldn't be better to stay with native php way and use Exceptions since the lib seems to targeting php 7.1?

Referencing: https://github.com/j-arens/wp-rest-router/blob/master/src/WordPress/Rest/CallbackWrappers.php#L19

Why constructor should take care of hooking into WordPress

Seeing this class constructor https://github.com/j-arens/wp-rest-router/blob/master/src/WordPress/Rest/DispatchListener.php I was wondering to know why the constructor is responsible of define the integration to WordPress?

I see this is a library and as such wouldn't be preferable to have a service provider and let the application (may be the plugin or "theme) decide where to integrate it?

May be instead of a service provider or as part of a configuration step there could be a class or something which take care of the bootstrap leave the class constructors free to do what they have to do, construct instances.

Recommend Projects