jacekschae / conduit Goto Github PK

I was just looking over this repo and noticed that the final JS file is way too big.

I recommend generating a build report but the offenders that shouldn't be included are cljs.pprint and cljs.analyzer. Don't know who is responsible for including those but my guess is on the re-frame tracing stuff.

Try

$ shadow-cljs run shadow.cljs.build-report app report.html
# then open report.html

This do doesn't look right because the first expression is not side-effecting (and is lost ... it could be deleted):
https://github.com/jacekschae/conduit/blob/master/src/conduit/events.cljs#L325-L327

Live-Reload is broken due to the repeated calls of hook-browser-navigation!. The goog.History instance can only be constructed once as it will wipe the DOM completely if constructed a second time after the page has finished loading.

It could be changed to a defonce instead and just removing the hook-browser-navigation! call.

(defonce history
  (doto (History.)
    (gevents/listen
      EventType/NAVIGATE
      (fn [event]
        (secretary/dispatch! (.-token event))))
    (.setEnabled true)))

I spend better part of this weekend to swap the router and refactor few thigs. Everyting seems to be working pretty well in dev. When I run yarn release it builds but when i put it in production it says:

ReferenceError: conduit is not defined
<script>window.onload = function() { conduit.core.main(); }</script>

Which is pretty obv but still can't figure it out ... . I think this might be a silly mistake on my side ...

Deployed version with errror: https://jacekschae.github.io/conduit-re-frame-demo/

Any ideas @thheller?

Hello!

Due to governance changes, we are now using the realworld.io domain for the RealWorld demo (both client and API).
Requests from conduit.productionready.io are redirected to api.realworld.io, but such a redirection might lead to inconsistent responses.

We encourage domain change for the community.
If this repository is maintained anymore, we'll consider hosting a demo of your implementation in a few weeks with the domain change.

The demo link will be added to the RealWorld documentation.

I tried the build process on the README with Java 8 and got "Unrecognized option: --add-modules"
It works with java 9. You might want to mention this in the README

Add spec for db and check-speck-interceptor

Minor thing I encountered but on my Windows machine (Git Bash MinGW), following README instructions failed. It appears that the end-of-string semicolons at package.json scripts key are causing problems.

shadow-cljs - starting ...
No config for build "app;" found.
Available builds are: npm, app
Done in 60.56s.

Simply removing them will make it work. Guess this doesn't happen on a true nix* (or OSX for that matter) as others, including author, would likely to have caught it. I figure removing them wouldn't harm either though ...

There are still calls for :complete-request in :login-success,:register-user-success and update-user-success but the handler was removed in 25fccc61c23571d9d94b33a46bf1eb97a7ca8550 (April 18).

I presume it shouldn't be called anymore?

Very interested in using this project as a base for a frontend for Datomic.
I notice that there is no project.clj, so it's not clear how the additional code could be added.
Looking for ideas.
Thanks.

Steps to reproduce:

1. clone the repo
2. yarn install
3. yarn dev
4. shadow-cljs gives this log: duplicate resource day8/re_frame/tracing.cljc on classpath, using jar:file:$HOME/.m2/repository/day8/re-frame/tracing-stubs/0.5.1/tracing-stubs-0.5.1.jar!/day8/re_frame/tracing.cljc over jar:file:/$HOME/.m2/repository/day8/re-frame/tracing/0.5.1/tracing-0.5.1.jar!/day8/re_frame/tracing.cljc

Expected:
Function Trace enabled by default

Actual:
Function Trace not enabled

Fix:
Commenting out tracing-stubs fixes this, but I don't think it's a good idea.

                 ;; [day8.re-frame/tracing-stubs "0.5.1"]