jadnco / locus-backend Goto Github PK

Apparently, GitHub does not support relative SVG images.

This issue will be used to upload images and get absolute URLs.

This issue mostly has to do with this:

router.route('/users/:id/spots')
  .get((req, res) => {
    User.getSpots(req.params.id, req, res);
  })
  .post((req, res) => {
    Spot.create(req.params.id, req, res);
  })
  .delete((req, res) => {
    Spot.remove(req.params.id, req, res);
  });

What I need to figure out is:

• Does a new Spot get created at users/:id/spots or just /spots
• Does the spotter id association come from the :id in the URL or is it sent as part of the body.

The backend is now at a point where there are many associated relationships between models, this is introducing a new problem regarding asynchronous flow.

This is the current state of the User.create method. As associations grow, promises end up being called within promises.

I'm not liking where this is heading, I can only imagine having to add more relationships – which will make this code even harder to keep track of.

I think it's worth it to look into ES6 generators – static *create() { yield; }. Also looking into this will help in understanding iterators in general.

static create(req: Object, res: Object): void {
    let user = new User(req.body.user);
    let followers = new Followers();
    let spots = new Spots();

    // Define user -> followers association
    user.users = followers._id;
    followers.user = user._id;

    // Define user -> spots association
    user.spots = spots._id;
    spots.user = user._id;

    // Persist the user record
    user.save()
      .then(_user => {

        // Persist the associated followers record
        followers.save()
          .then(() => {

            // Persist the associated spots record
            spots.save()
              .then(() => res.json({ user: _user }))
              .catch(err => res.send(err));
          })
          .catch(err => res.send(err));
      })
      .catch(err => res.send(err));
  }

A login system needs to be set up for users. I don't think it's necessary to have a custom system for this, being able to login with either Twitter or Facebook would suffice.

This Passport middleware for Express should make things super easy: https://github.com/jaredhanson/passport

https://devcenter.heroku.com/articles/s3-upload-node

Before this app goes live (or if it goes live) the images should just be able to get uploaded and saved onto my personal machine.

Obviously, this shouldn't be an issue because I will be the only person using it.

Using the module multer will make this easy; https://www.terlici.com/2015/05/16/uploading-files-locally.html