jah2488 / mongoid-magic-counter-cache Goto Github PK

there's a "require 'pry'" in magic_counter_cache which i guess is redundant and causes the gem not to work if one doesn't have pry installed.

When i remove the require pry everything seems to be working fine.

RubyGems.org doesn't report a license for your gem. This is because it is not specified in the gemspec of your last release.

via e.g.

spec.license = 'MIT'
# or
spec.licenses = ['MIT', 'GPL-2']

Including a license in your gemspec is an easy way for rubygems.org and other tools to check how your gem is licensed. As you can image, scanning your repository for a LICENSE file or parsing the README, and then attempting to identify the license or licenses is much more difficult and more error prone. So, even for projects that already specify a license, including a license in your gemspec is a good practice. See, for example, how rubygems.org uses the gemspec to display the rails gem license.

There is even a License Finder gem to help companies/individuals ensure all gems they use meet their licensing needs. This tool depends on license information being available in the gemspec. This is an important enough issue that even Bundler now generates gems with a default 'MIT' license.

I hope you'll consider specifying a license in your gemspec. If not, please just close the issue with a nice message. In either case, I'll follow up. Thanks for your time!

Appendix:

If you need help choosing a license (sorry, I haven't checked your readme or looked for a license file), GitHub has created a license picker tool. Code without a license specified defaults to 'All rights reserved'-- denying others all rights to use of the code.
Here's a list of the license names I've found and their frequencies

p.s. In case you're wondering how I found you and why I made this issue, it's because I'm collecting stats on gems (I was originally looking for download data) and decided to collect license metadata,too, and make issues for gemspecs not specifying a license as a public service :). See the previous link or my blog post aobut this project for more information.

From what I read in the readme, seems like this definitely works on embedded documents whereas its ambiguous in the docs of mongoid built in counter cache .

Thats just one example.

Are you planning to bump 1.1.1 to rubygems?

If you're going to require pry, you should really add it to the gem dependencies. Thanks for writing the gem!

Hi, I have the next problem:

class Library
  include Mongoid::Document

  field :name
  field :city
  field :book_count
  has_many :books
end

class Book
  include Mongoid::Document
  include Mongoid::MagicCounterCache

  field :first
  field :last

  belongs_to    :library
  counter_cache :library
end

> library = Library.create
 => #<Library _id: 53271d5a7cf9782c8b000005, name: nil, city: nil, book_count: nil> 
> book = Book.create
 => #<Book _id: 53271d6d7cf9782c8b000006, first: nil, last: nil, library_id: nil>

> book.library = library
 => #<Library _id: 53271d5a7cf9782c8b000005, name: nil, city: nil, book_count: nil>
> book.save
 => true
> library.reload.book_count
 => nil

How you can see, the library book_count don't be updated when we assign the library to book. This is a bug ?

Thanks.