jaikeerthick / composable-graphs Goto Github PK

Hello, I'm interested in your open source!
I have some questions!

The current version of compose is 1.1.0, can you version up?
Or can I contribute to the update of the compose version?

This is a nice library, and I would like you to consider a few enhancements. I will create one by one.

The first one is to handle edge cases. Specifically, for line charts:

1. Display a single point if the number of data is 1
2. Do not crash if there is no data. Perhaps display an empty graph is fine.

When there are many many points flooding in, x-axis labels are overwhelmed. It would be nice if it could be decoupled. For example, accepting a function to convert point data to labels, and accept a parameter to control the density of labels.

This might be a breaking API change.

I wish the density of grid lines could be configured as well.

Describe the bug
When your largest number in the line graph contains a decimal and is not a whole number, it goes above the graph.

To Reproduce
Steps to reproduce the behavior:

1. Create a LineGraph composable
2. Give it's biggest point on the graph a decimal value
3. look at graph

Example data to replicate issue:

listOf(
        LineData(x = "Mon", y = 0),
        LineData(x = "Tues", y = 0),
        LineData(x = "Wed", y = 0),
        LineData(x = "Thurs", y = 0),
        LineData(x = "Fri", y = 2.59999999),
        LineData(x = "Sat", y = 0),
        LineData(x = "Sun", y = 0),
    )

Expected behavior
To see points within graph

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

• Device: Pixel 3a
• Android Version: API 33
• Library Version [v1.2.3]

Additional context
Add any other context about the problem here.

It would be nice if we could add multiple lines to the same LineGraph. It would be useful to comparing different data.

Can I change the label position from right to left??

Would you support Compose Multiplatform?

I just have a quick look on the source code. It seems the core does not depend on Android-specific stuffs, so it might not be difficult. If you have no time, would you accept a PR?