DiskLruCache#STRING_KEY_PATTERN does not allow capital letters in cache keys about disklrucache HOT 9 CLOSED

Case insensitive file systems like on a Mac.
On Sep 19, 2014 4:23 AM, "David A. Velasco" [email protected]
wrote:

Is there any reason for this constraint?

Thanks.

—
Reply to this email directly or view it on GitHub
#73.

from disklrucache.

That is not very common in Android devices.

Would you consider to add a method to set the regexp value?

from disklrucache.

That seems like something that is not a widespread need. Why do you need
upper-case in your keys?

On Mon, Sep 22, 2014 at 2:48 AM, David A. Velasco [email protected]
wrote:

That is not very common in Android devices.

Would you consider to add a method to set the regexp value?

—
Reply to this email directly or view it on GitHub
#73 (comment)
.

from disklrucache.

We are reusing other identifier of the files we want to cache, and may include capital letters. We'd rather not having a separate identifier just for the cache.

from disklrucache.

Should the DiskLruCache#validateKey method be public to be able to override it?

from disklrucache.

The class is final.

from disklrucache.

So I supposed @davivel would have to do a downcase to its keys,

from disklrucache.

Case insensitive file systems are everywhere, including Android. You're better off hashing your file name when creating a cache key.

from disklrucache.

We already solved it, thanks.

from disklrucache.