jakobo / hotp-php Goto Github PK

The GetTime() method is completely unnecessary because it returns a stamp which is time zone agnostic. The only time zone that has to be right for unix time to work properly is the server's time zone which changing the PHP zone will have no effect over.

Hi,

Thanks for this. Please could you consider adding as composer.json file, so that your code can be installed/managed via composer?

David

Might just be as simple as allowing ^8.0 in the composer.json requires...

I've been out of the PHP game for a while, and the tooling in composer has simply gotten much better. So that future commits and code are protected against awkward { and } placement, we should use something to automate the formatting of commit code instead of relying on VS Code to do the heavy lifting.

Ideally, we'd use something like GrumPHP, directly use PHP-CS-Fixer, or add Husky/Lint-Staged tasks via node.

/cc @jrzepa in case I'm missing anything from #13 where the original commit was to get our code standards up to par

I've added this basically to packagist at https://packagist.org/packages/jakobo/hotp-php (more than happy to add you as a maintainer on that packagist package if you give me a username)

Can you tag a release (version number is dealers choice) so people can start bringing this in, rather than having to use dev-master from packagist as is? :)

Hey @jakobo

Any chance you could setup Travis/CI again on this repo?

Thanks!

Some unit tests would proably be beneficial

example.php provides a good set of testing criteria that probably helps do a lot of the testing...

As of writing, only https://github.com/Jakobo/hotp-php/blob/ea29559/src/HOTP.php#L34-L37 is untested

Not a big deal, but would be nice to get 100% coverage sometime ;)