jamesknelson / m-and-c-in-mvc-talk Goto Github PK

Hi James,
I really enjoyed your talk at ReactNext, especially the part about 5 types of state - I think it was spot on. Hoped you enjoyed Israel 😎

I think there are a few inaccuracies in your analysis of connected components rendering-

Now every mounted connect gets re-rendered on each keypress

This shouldn't happen if you keep your state immutable since Redux will figure out that the state for these components didn't change with a simple shallow equality check and will prevent the rendering of these components using shouldComponentUpdate

Dispatch request for Invoices
Re-render the Invoice connect
Re-render the Inner Container
Oops, there is no data...
Dispatch request for Invoices
...
Profit?

This should also not be a problem since the inner component's componentDidMount (where usually you would place a dispatch call for fetching data) should not be called a second time, as it is already mounted. Furthermore, keeping isFetching and didInvalidate flags in the state tree would be sufficient to avoid any case of double fetching. This technique can be seen in Redux's official docs.

Am I missing something here?