jamespdaily / pf2e-sheet-skill-actions Goto Github PK

Skills should roll from the actor sheet, not the selected token

I really like the module because it does a great job of reminding players what their options are, but I have noticed that clicking the icons or trying to expand a description of the actions does nothing. The only way to see a description of the action is to roll.

Since I figure players might want to brush up on how a skill action works before they commit to rolling for it, would it be easy to add a description to the skill actions in the module?

Example: https://cdn.discordapp.com/attachments/513918036919713802/930943814447800350/Example_Skill_actions.gif

Minor issue - it'd be nice if the "fas fa-tshirt" icon used for toggling the visibility of the actions on/off were an eye icon instead (more standard UI - tshirt icon makes sense for equipment equipped or not, but not so much for skill visibility)

Currently clicking on picture of skill action doesn't do anything. It would be nice if it would send the description of the action to the chat similarly how clicking on actions in actor sheet does.

Should function like the strikes where clicking a skill will drop down its description

The module no longer works after the system was updated.

It throws the following error:

Thanks to Glunty for #44, although I don't think that's quite the module name! Suggest changing it to match the module's name, "PF2e Sheet Skill Actions".

Solution described here. Think I understand the issue and can make a PR in the coming days; bit busy right now. As an aside, I'd respectfully recommend consistency with the module name; I've seen pf2e-sheet-skill-actions, sheet-actions, sheet-skill-actions, and SkillActions used variously!

When you click one of the buttons to roll, nothing shows in chat.
This error is from Intimidate: Demoralize

Request is to allow the actions to be dragged to the macro bar like other actions.

Add rolls for assurance for those that have the skill

skill-actions.html has several inline styles. We could benefit out of extracting them to a separate CSS file.

The new way of handling assurance (single skill feat) isn't being detected by the module.

Looks to be a change in the way it is sluggified.

Recall Knowledge (1A):
|Society +0| |Occultism +4| (etc...)

@andriusch what ya think?

You can't use roll income button because it throws error. It seems game.pf2e.actions.earnIncome requires parameters which we don't pass.

As the title says, after updating my pf2e system to v3.11.0.3, the skill actions added by this module—including the header for it—are vacant from the character sheet.

The following error message appears upon opening a character sheet:

Tested in a fresh world with no other modules activated.
Foundry version 9.269
pf2e system version 3.11.0.3
pf2e-sheet-skill-actions module version 1.2.0

With the clever improviser feat (https://2e.aonprd.com/Feats.aspx?ID=74), you can try a skill check that requires to be trained even if you are not. They should be added to the sheet if the actor has this feat (feat.data.slug="clever-improviser")

Currently, 'custom' actions (and reactions + free actions) are displayed below the skill actions added by this module. Since there are many skill actions, most of which are far less used than these 'custom' actions granted by ancestry/class/etc., I think it would be useful to move skill actions below them. This way you don't need to scroll for as long, which perhaps saves me a couple of muscle tugs!

Is it possible to add a way to collapse the whole skill actions header? or possibly place it below the more character specific actions and reactions?

The feat name used here is translated, so it won't work on a non-english system install.
Use feat.data.data.slug instead

This may be a tricky one.
But say I have a +1 Warhammer worn, which has the shove trait.
Perhaps the module will add a toggle for me to add the +1 item bonus to my shove?

A good module I would like to have in french. Is there a way to use localization ?

E.g.:

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'modifier')
[Detected 1 package: pf2e-sheet-skill-actions]
    at new SkillAction (modules/pf2e-sheet-skill-actions/module/sheet-skill-actions.js:19)
    at initializeSkillActions (modules/pf2e-sheet-skill-actions/module/sheet-skill-actions.js:63)
    at modules/pf2e-sheet-skill-actions/module/sheet-skill-actions.js:53
    at Function._call (foundry.js:294)
    at Function.call (foundry.js:279)
    at FamiliarSheetPF2e._render (foundry.js:3086)
    at async FamiliarSheetPF2e._render (foundry.js:3733)

As this module is probably not very useful for anything but characters you might want to consider adding something like this in the renderActorSheet hook.

  if (app.actor.type !== 'character') {
    return;
  }

Module does not work with v10

With the recent updates, there's a lot of skill actions. If you want only a small selection of skill actions to be displayed (as opposed to an 'all but ...' perspective), it's very tedious to unequip each one, especially as the character sheet's scroll position resets each time.

This request would add some mechanism to either equip all unequipped skill actions (reset to defaults), and unequip all equipped skill actions (hide everything). I'd suggest something like right-, SHIFT-, or CTRL-clicking the toggle-equipped button, if you can sort out a tooltip to expose this functionality to general users.

I notice that the actions included in the module are limited to just the most combat-focused of the options. There's plenty of other skill actions that PCs might regularly roll...balance, climb, sneak, swim, tumble through, and so on. I suspect your goal was to not clutter things up...maybe have a dividing line putting the combat actions at the top, a separator and then the movement ones, and maybe more misc at the bottom? Down the line you could even have a simple options menu to display or not particular categories of actions.

Module seems broken with last system release 3.4
I'm investigating...

EDIT : Nevermind, not broken, a clean cache solves the problem.
Just missing a bit of css for the title

The pf2e system provides translations for actions, it would be prefereable to use them instead of redefining them in skill-actions-data.ts :

PF2E.Actions.Disarm.Title
PF2E.Actions.Demoralize.Title
PF2E.Actions.Grapple.Title
PF2E.Actions.Trip.Title
PF2E.Actions.Shove.Title
PF2E.Actions.Feint.Title
PF2E.Actions.BonMot.Title

FVTT: V9
Build: 255
Pathfinder 2e: 3.7.0.10781 and earlier.

Active Modules: PF2e Character Sheet Skill Actions 0.9.0 and earlier

When you have scrolled down in the inventory and change any quantity of any item (+1 or -1) the scroll will reset to the top of the inventory.