Giter VIP home page Giter VIP logo

pytrs's People

Contributors

jamespimes avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

pytrs's Issues

Clean up readme.md

TODO: Clean up the readme.md, especially linebreaks that are not being parsed as such.

Incorrect parsing of 'cross-halves' that should be described as quarters.

Descriptions such as 'N/2E/2SW/4' are not being handled correctly. Specifically, the N/2 of the E/2 is more simply described as the NE/4, which is how it almost always appears in real-world data. However, the 'N/2 of the E/2' is technically an accurate description of the same tract, and it does appear from time to time.

QQ parsing currently returns this as ['N2NESW', 'N2SESW'] (at qq_depth_min=2), but it should actually return ['NESW'].

This is only a problem when the 'axis' of the halves is different -- i.e. the 'W/2E/2SW/4' is parsed correctly, because the E/2 and W/2 are both divided on the same axis; whereas the N/2 is divided on a different axis than the E/2.

Possible (untested) solution in unpack_aliquots() is:
-- after breaking down the aliquot_text_block into component_list, and before running subdivide_aliquot() on each component...
-- look for any 2 consecutive halves in the component_list (checking largest-to-smallest subdivision -- i.e. left-to-right in the list), and if and only if they are NOT on the same axis, replace the pair of them with the appropriate quarter.
-- Continue the rest of the function.

So, for example, after the 'W/2N/2E/2SW/4' has been broken down into ['SW', 'E', 'N', 'W'], we would replace 'E' and 'N' with 'NE': ['SW', 'NE', 'W'].

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.