jamesward / cloud-run-button Goto Github PK

The README does not really show the user experience. the only way to see it is to actually try it.

We could better convey the experience by embedding an animated gif of what it does to click the button.

This button is awesome but I got a little bit confused by some of the prompts in Cloud Shell. I clicked the button and then chose the "I don't trust the repo" option. I think this caused me to need to authenticate since my credentials weren't shared in the environment.

Specifically, I was confused by the line in bold:

Your Cloud Shell Environment is running Docker image gcr.io/cloudrun/button@sha256:7337e613f4275765eef36faf33ae7ab67903901b22d03989742d686b48e14a25
Welcome to Cloud Shell! Type "help" to get started.
To set your Cloud Platform project in this session use “gcloud config set project [PROJECT_ID]”
cloudshell_open --repo_url "https://github.com/jamesward/cloud-run-button.git"
stewartr@cloudshell:~$ cloudshell_open --repo_url "https://github.com/jamesward/cloud-run-button.git"
Cloning into 'cloud-run-button'...
remote: Enumerating objects: 16, done.
remote: Counting objects: 100% (16/16), done.
remote: Compressing objects: 100% (14/14), done.
remote: Total 16 (delta 2), reused 15 (delta 1), pack-reused 0
Unpacking objects: 100% (16/16), done.
cd-ing into cloud-run-button
You need to authenticate to continue
Go to the following link in your browser:

Enter verification code:
Updated property [run/region].
You have access to 1012 projects, so search for the one you want:
Query:

Maybe I have access to too many projects and this issue wouldn't affect most users. Ideally, I would have liked to see something like:

...
Enter verification code:
Updated property [run/region].
Select a project. You have access to 1012 projects, so search for the one you want:
Query:

Currently, cloud-run-button uses REPO_NAME as container image repository and Cloud Run service name. It seems not to be configurable.
Because Cloud Run forbids service name which starts with a number, cloud-run-button is not compatible with some GitHub Gist repository.

ERROR: (gcloud.beta.run.deploy) INVALID_ARGUMENT: The request has errors
- '@type': type.googleapis.com/google.rpc.BadRequest
  fieldViolations:
  - description: Service name must use only letters, numbers and '-'. Must begin with
      a letter and cannot end with a '-'. Maximum length is 63 characters.
    field: metadata.name

Ref: https://gist.github.com/apstndb/63022c10ca5e94ed6e7c1dff9d5dbeaf

The button looks a bit pixelated as PNG. Since it is a vector graphic in the first place, we could create and use https://storage.googleapis.com/cloudrun/button.svg

I can take care of that, I probably have the asset on my machine.