janboddez / add-fediverse-icons-to-jetpack Goto Github PK

It's probably smart to check the jetpack_social_menu_get_svg() function actually exists, so as not to trigger any fatal errors.

Hi,

is there a Fix?

The function_exists('jetpack_social_menu_get_svg') returns false even when the Jetpack class exists.

On (older) sites that just support Jetpack's social menu (e.g., those running "older" Automattic themes), there doesn't seem to be an issue.

I've used this plugin for a bit, and with other themes, it works well. However, when using twentytwenty, it doesn't seem to set the icons correctly.

Is it due to TwentyTwenty using it's own setup?

…Just as the title says, and since Bluesky will be federating its protocol soon, it’d be nice to have a “Share to Bluesky” Jetpack link added using their 🦋 icon.

Issues · janboddez/add-fediverse-icons-to-jetpack by janboddez ( GitHub)

Add Fediverse icons to your WordPress site’s social menu. – Issues · janboddez/add-fediverse-icons-to-jetpack

(Originally published at: https://starrwulfe.xyz/t/1yp6)

We may have been lucky with the current 2020 workaround.

Right now, when an instance of the main plugin class is created, it's referenced nowhere, and thus hooks can't be removed. Static methods would solve that, as would the "Singleton" pattern.

See #7.

There may be another conflict, though, and that's that there would be two SVG symbols with id="icon-mastodon". Not sure which one browsers would pick, presumably the first one, but it'd still "invalidate" the HTML. Anyway, that I can fix with a prefix.

Current versions of plugin / Jetpack do indeed clash here, although it doesn't seem to show. Still, the markup is invalid so we should fix.