jannisbecker / ve-rs Goto Github PK

Hi, firstly thank you for this crate, it has been useful for something I'm working on :)

I just wanted to point out that I believe the condition in the sanitize_asterisk function is the wrong way around.

The current code is as follows:

fn sanitize_asterisk(value: &str) -> Option<String> {
    if value.is_empty() || value == "*" {
        Some(value.into())
    } else {
        None
    }
}

To my understanding, an '*' indicates a lack of a relevant value in the MeCab format, which we would presumably want to represent as None. If not an empty string or '*', then presumably we want to keep the lemma. Instead, this code does the opposite.

I changed it to this (the same but shorter and with the condition is inverted):

fn sanitize_asterisk(value: &str) -> Option<String> {
    (!value.is_empty() && value != "*").then(|| value.to_string())
}

Now for example entering the input ’難しかった' results in a Word instance where lemma is Some("難しい".to_string()) whereas before my change it was just None.

Please let me know if I'm missing something, I'm not super familiar with MeCab and such.