Scale factor in jb_SVGComponent is always 1 about resvg4juce HOT 3 CLOSED

Thanks for verifying that!

I just pushed an according change that should fix it a87c33d

from resvg4juce.

Thank you for bringing that up. I just did a quick test on macOS on my MacBook Pro with a high res Retina display. Here the current scale computation correctly returns a scale factor of 2.0 which is expected, while getApproximateScaleFactorForComponent() returns 1.0.

If I get all that right, the correct approach will probably be multiplying both scale factors to retrieve the overall correct scale factor? It's been a while since I wrote this code, but I vaguely remember that I also got non 1.0 scale factors on Windows in some scenarios, so I would at least want to do some tests if this addition would not break anything in my Windows test environment before adding this. Will try to test that as soon as possible

from resvg4juce.

I think multiplying the scale factors would be better indeed. I tested my plugin in Standalone mode, and the original scale factor juce::Desktop::getInstance().getDisplays().getDisplayForPoint(getBounds().getCentre())->scale was 2.5 and getApproximateScaleFactorForComponent(this) was 1 . It seems that the original code is working, except for hosted VST plugins on Windows.

Multiplying both of them would take into account the display scale factor, and the additional transforms applied to the component (like Desktop::getInstance().getGlobalScaleFactor(), or the scaling factor applied on VSTs on Windows) https://github.com/Riuzakiii/Resvg4JUCE/commit/0ff91eb34e9f45543254d24f586450988b455fcc .

from resvg4juce.