janosgit / resvg4juce Goto Github PK

Hi,

I'm using Resvg4JUCE in a VST3 plugin because JUCE's svg support is lacking some functionalities. I've run into an issue when dealing with the DPI scaling factor on Windows (I did not test this on macOS).

In the resized() method of jb_SVGComponent, auto scale = juce::Desktop::getInstance().getDisplays().getDisplayForPoint (getBounds().getCentre())->scale; is always 1 on my display, when the scaling factor should be 2.5. This is apparently intentional in JUCE according to this post for instance Displays::Display::scale always 1.0 from within windows DAWs.

I've implemented the solution given in the above forum topic here https://github.com/Riuzakiii/Resvg4JUCE/commit/8e49fab7b53866d9c32dad5c23bff9027c64004b which seems to fix the problem. Do you see any issues with this fix ?

Thanks

I think instead of maintaining a fork whose only purpose is to change the crate type, I suggest a script that alters the Cargo.toml before calling cargo build

Hi,

I think using getBounds().getCentre() to find the current display of the app might be wrong, getScreenBounds().getCentre() should be used instead master...Riuzakiii:master.

I've tested this code with the Standalone version of a VST plugin, I now have the right scale factor for each of my displays.