jasbrake / actionfps-log-stream Goto Github PK

So that I can run it with:

$ npm install -g actionfps-log-stream
$ AUTHORIZATION="..." actionfps-log-stream log-file.tsv

Depends on #1

2017-09-27 02:27 +00:00: Error: write after end
    at writeAfterEnd (_stream_writable.js:234:12)
    at WriteStream.Writable.write (_stream_writable.js:285:5)
    at EventSource.eventSource.addEventListener (/usr/lib/node_modules/actionfps-log-stream/actionfps-log-stream.js:48:17)
    at emitOne (events.js:115:13)
    at EventSource.emit (events.js:210:7)
    at _emit (/usr/lib/node_modules/actionfps-log-stream/node_modules/eventsource/lib/eventsource.js:222:17)
    at parseEventStreamLine (/usr/lib/node_modules/actionfps-log-stream/node_modules/eventsource/lib/eventsource.js:237:9)
    at IncomingMessage.<anonymous> (/usr/lib/node_modules/actionfps-log-stream/node_modules/eventsource/lib/eventsource.js:200:11)
    at emitOne (events.js:115:13)
    at IncomingMessage.emit (events.js:210:7)

I think the issue is that I am ending the writeStream on an error event from the eventsource server.

You look for the latest line to find the time.

When reading from the stream it'll read from that specific time onward - which could mean quite a few duplicate messages.

However, reading 'after' that time is not good either because there may be some messages that were missed.

Use the approach here:
https://github.com/ScalaWilliam/ActionFPS/blob/master/log-server/actionfps-log-sync.sh#L21-L26

• ### is unsupported markdown for npmjs.com
• Add a full example about how to run
• Add example for running with PM2

So that the user wouldn't need to modify config.js and so that publishing to npmjs would yield a self contained package.

Most important config option is AUTHORIZATION.

logFilePath on the other hand is an argument and not configuration (you can have multiple log files, but only one auth token typically).

Current Behavior

If you call the program without a file parameter, it will try to resolve the filepath of '' (empty string) and fail.

What it should do

It should: let the user know that they need to pass in a file path as a parameter in order to run it.

Also

Similarly, I need to decide whether it is best to leave File not found errors unhandled, or print a friendly error message and exit.

As per this comment, I need to split by the tab character.