jastorgalj / smart-codegen Goto Github PK

It is imperative that java.util.Collection and java.util.Map is supported
out of the box in the same manner as List and Set.

What steps will reproduce the problem?

1. Using netbeans 6.0.1 (I know you said 6.1 but I am sick of the crashes
on 6.1) try to install the downloaded plugin
2. States that the following plugins are required;

Javac API Wrapper [module org.netbeans.libs.javacapi > 0.6.0.1] Java Source
[module org.netbeans.modules.java.source > 0.32.0.3.6] File System API
[module org.openide.filesystems > 7.7] Nodes API [module org.openide.nodes
> 7.3.0.1] Text API [module org.openide.text > 6.17] Utilities API [module
org.openide.util > 7.12.0.1
3. Tried to get the above plugins from here
(http://plugins.netbeans.org/PluginPortal/faces/MainPage.jsp) by searching
for the module name, installed all the modules I could conforming to the
module names <why do I need a dilber module ??>

What is the expected output? 
You toString module can be installed after a restart (after successful
install of above modules)

What do you see instead?
Just keeps asking for the same modules

What version of the product are you using? On what operating system?


Please provide any additional information below.

Currently the separator between fields in the output String is new line.
I think this should be customizable.

[revision 41 from the svn]

Taking look at LoggerGenerationFactory I see that Tree.toString() is used
and then textual comparisons are used (at least to find
(System.)?out.print(ln)?). I do not think this is completely correct, for
at least two reasons:
-to my knowledge, the result of com.sun.source.Tree.toString() is not
specified, and may change.
-textual comparison is generally unsafe, "out.print" does not necessarily
mean printing to System.out despite the j.l.System.out is imported
statically. For example, consider this code:
----------------------------------------------------------
package test;

import java.io.PrintWriter;
import java.io.StringWriter;
import static java.lang.System.out;

public class Main {

    public static void main(String[] args) {
        PrintWriter out = new PrintWriter(new StringWriter());

        out.println("test");
    }

}
----------------------------------------------------------

Invoking the tool to convert System.out into Logger, it converts the
out.println, although it is not a j.l.System.out.println call.

I would recommend to use Elements to check whether a method print(ln)? is
called on j.l.System.out, e.g.:
1. look whether methodInvocationTree.getMethodSelect is MEMBER_SELECT (if
no, no call to j.l.System.out.print)
2. check whether the identifier of the member select is "print(ln)?"
3. using Trees.getElement resolve the memberSelect.getExpression() to
Element, and check whether it is System.out.

toString is really great, but it would be nice if it moved to the insert
code section, so it is shown when pressing Alt+INS 

As toString() when declared is always basically overriding one it is thus
needed that @Override annotation is declared for it.