java-sepa-xml / java-sepa-xml Goto Github PK

Hi, thanks for work. Really helped me get things going.

I faced two minor issues:

1. According to this document (https://www.nordea.com/Images/36-262430/MIG-CAP_pain%20001.001.03_Payments_v_1.5.pdf) valid codes in the used standard (pain.001.001.03) are CHK and TRF. So I altered SEPA.Java and with TRF everything works fine.

2. When I created a credit transfer file the subject was left out. I altered the last lines in SEPACreditTransfer.java to nodeCdtTrfTxInf.append("RmtInf").append("Ustrd").value(transaction.getSubject());

From my understanding Remittance can't be set at all while using credit transfers.

Have a nice weekend

How to import the library in my project?

from the wiki:
https://wiki.xmldation.com/General_Information/ISO20022/pain.008
Pain.008 is a payments initation message by ISO 20022. It depicts a Direct Debit message in XML format.

https://wiki.xmldation.com/General_Information/ISO_20022/pain.001
Pain.001 is a payments initiation message by ISO 20022. It depicts a Credit Transfer message in XML format.

Question:
Since the SepaDirectDebit constructor calls the super build, how would it be possibe to create a pain 008 file?
THe build(0 is hard coded on pain.001.001.03.

Alos, how did you generate the example in the readme -> XML File Result for SEPA Direct Debit

And 'XML File Result for SEPA Credit Transfer' has the wrong document xmlns reference (pain 8 instead of 1)

Regards,
Daniel

In PAIN 001.001.03, BIC is optional as the account is fully specified with the IBAN. So I provide a pull request to account for BIC being null in BankAccount object when using the two-arguments constructor.

As a second thing, I updated pom.xml to depend from a newer version of the surefire plugin to mitigate compiler errors.

Please check and apply.

Best regards
Alexander