Spotless formatting implementation proposal about javaparser HOT 13 OPEN

If we go for this approach, then I'll add a comment to open PRs pointing them at this issue for the guide on how to update PRs

from javaparser.

I've opened #4409 as a PR for step 1 of the reformatting process. It's fine if there end up being some commits merged between this one (assuming it's accepted, of course) and the big format. In this case, just replace the <spotless> commit in the process above with the last commit before the big reformat.

from javaparser.

An idea I had from #4414 is that, if automatic reformatting is supported, we could probably add a CI workflow to run the code generators, reformat the code, and fail if the diff is non-empty. This would ensure that everything was generated correctly and that nothing is merged to master that would be overwritten by code generators.

from javaparser.

I need to take some time to look at this proposal.

from javaparser.

Of course! I understand that this would have a major impact on the codebase and is not a decision to be taken lightly. If, at any point, you have any questions or concerns, I would be happy to discuss them :)

from javaparser.