javidpack / itemchecklist Goto Github PK

There is a bug with counting items from Void Vaults. When 'Toggle Collect Chest Items' is enabled and you open a Void Vault, the game will become unresponsive to keyboard inputs.

The client.log shows the following error.

[15:00:38.821] [Main Thread/WARN] [tML]: Silently Caught Exception:
System.IndexOutOfRangeException: Index was outside the bounds of the array.
at ItemChecklist.ItemChecklistPlayer.ChestCheck() in ItemChecklistPlayer.cs:line 103
at Terraria.ModLoader.PlayerLoader.PreUpdate(Player player) in tModLoader\Terraria\ModLoader\PlayerLoader.cs:line 186
at Terraria.Player.Update(Int32 i) in tModLoader\Terraria\Player.cs:line 17966
at Terraria.Main.DoUpdateInWorld(Stopwatch sw) in tModLoader\Terraria\Main.cs:line 13485
at Terraria.Main.DoUpdate(GameTime& gameTime) in tModLoader\Terraria\Main.cs:line 13131
at Terraria.Main.Update(GameTime gameTime) in tModLoader\Terraria\Main.cs:line 12686
at Microsoft.Xna.Framework.Game.Tick() in D:\a\tModLoader\tModLoader\FNA\src\Game.cs:line 546
at Microsoft.Xna.Framework.Game.RunLoop() in D:\a\tModLoader\tModLoader\FNA\src\Game.cs:line 878
at Microsoft.Xna.Framework.Game.Run() in D:\a\tModLoader\tModLoader\FNA\src\Game.cs:line 419
at Terraria.Program.LaunchGame_(Boolean isServer) in tModLoader\Terraria\Program.cs:line 235
at Terraria.Program.LaunchGame(String[] args, Boolean monoArgs) in tModLoader\Terraria\Program.cs:line 196
at MonoLaunch.<>c__DisplayClass1_0.

I have never programmed a terraria mod... so my comment may not be a potential bug at all. Howerver, I find the prospect of this mod to be intriguing in a "got to catch them all kind of way"...

Assuming that the "banks" covers different extra storage tied to the player, such as Piggybank, Safe, Void and Defenders forge. Not sure which one is chich though. But the "if cases felt" incomplete compared to the number of banks defined for a player.

(ref: https://docs.tmodloader.net/html_alpha/class_terraria_1_1_player.html)

Even though we know what item are found by us, we don't know whether we only picked it up? Or we actually created them.

Haven't thought this through, but think this may be interesting.

Maybe when we show the tooltip, we show an extra line (or a glyph / icon) to indicate whether we ever crafted it.

Not sure whether it's doable or not.

But as a controller user, I can only toggle the mode pane. I cannot toggle the sort method, filter logic etc.

Anyway, thanks a lot for this mod! It's really cool! 👍

Sorry for opening so many issues. It's because I really love your work! 😆

This can be a number over the upper right corner of the item.

We can show the exact count of the item being collected or "999+" if it's just too many.

ItemChecklist v0.2.1
Terraria v1.3.4.4
tModLoader v0.9.2.3

Game crashes during the launch process without generating any log files in the logs folder

ItemChecklist was the only mod in the mods folder (in order to eliminate any external factors)

A simple switch that can toggle numbering of the items found or not found in the current sorting mode.
The numbers could maybe appear in place of the item stack number?
Just a suggestion

We can actually log the datetime when the item is first found / crafted.
With this data, we can sort the items by found date. This may be useful in two ways:

1. See recently found items
2. View complete history of Journey