Ran into a weird issue using this plugin. Not entirely sure whether it is actually caused by this library. When I attempt to run collect() on the value that resides in the request, I get an error that the array type is not accepted which makes zero sense to me.

$x = $request->validate(['values.*' => 'required|integer'])['values'];
dumpType($x); // array<int|string, int|numeric-string> 
$t = collect($x); // Parameter #1 $value of function collect expects Illuminate\Contracts\Support\Arrayable<int|string, int|string>|iterable<int|string, int|string>|null, array<int|string, int|numeric-string> given.  

The weird thing is, the inferred type should be accepted. When I instantiate a new variable and explicitly give it this type, PHPStan returns no errors:

/** @var array<int|string, int|numeric-string> $val */
$val = [1, '1'];
dumpType($val); // array<int|string, int|numeric-string>
collect($val); // No errors

I have no clue why the former code fragment displays and error but the latter does not. I figured there might be a small bug in the type inference.

Using PHPStan level 9

Hi there! I've run into a couple of type inconsistencies when using this plugin (at 26f81b6) under Laravel 9.x (9.48.0 specifically):

When using $controller->validate($request, [rules]) (as provided by Illuminate\Foundation\Validation\ValidatesRequests), the return type ends up as simply array rather than one with the type information provided:

// in a controller
$valid = $this->validate($request, [
    'amount' => 'required|integer',
]);
\PHPStan\dumpType($valid);

installed: Dumped type: array
not installed Dumped type: array

Similarly, when using $request->validate([rules]) (as apparently provided by Illuminate/Foundation/Providers/FoundationServiceProvider calling Request::macro('validate', ...)), the actual validated array is returned, rather than Illuminate\Validation\Validator. While the validated type is correct if I unwrap it with ->validated(), this will cause a crash at runtime since the framework has already unwrapped the value!

// also in a controller
$valid = $request->validate([
    'amount' => 'required|integer',
]);
\PHPStan\dumpType($valid);

installed: Dumped type: Illuminate\Validate\Validator

\PHPStan\dumpType($valid->validated()) shows: Dumped type: array{amount: int|numeric-string}
but doing this will crash at runtime!

not installed: Dumped type: mixed

In both cases, the actual value produced is:

['amount' => '1500']

In the former case, it looks like it should be handled by the FactoryMakeExtension (though the getClass() return value may not be picking up on the Contracts part of the namespace, but I tried changing it to no avail), so I'm totally lost.

In the latter case, I see the RequestValidateExtension returning the ValidatorType, so it appears to not be reflecting the fact that the framework calls validate() automatically.

Hopefully you find this feedback useful!

Hi - thanks for putting this together! It's helping me out a lot with typechecking Laravel validation results :)

I noticed that the following validation appears to be producing the wrong type:

        $valid = $request->validate([
            'amount' => 'required|integer',
        ])->validated();
        \PHPStan\dumpType($valid); //  array{amount: float|int|numeric-string}

Unless Laravel's integer validation is doing something really odd, it seems like the result of this should instead be int|numeric-string, without the float in the union.

I'm currently using dev-master 1fe0f3b of this extension.