jbechter / arduino-onewire-ds2438 Goto Github PK

Just a warning: the changes to this library only work by coincidence; in a few places, pointers to stack variables are returned so the library often cannot read the sensor.

to fix: change
void DS2438::begin(uint8_t mode) { uint8_t addr[8];
to
void DS2438::begin(uint8_t mode) { static uint8_t addr[8];

also, 'void getAddress(uint8_t *addr);' should be a pointer to a pointer.

Hi.
I've found that when using only channel B to read VDD with the following setup:
ds2438.begin(DS2438_MODE_CHB | DS2438_MODE_TEMPERATURE)
it is not possible to read the temperature value.
I think I've found a solution but as I'm new to GitHub I'm not sure how to do it, so here's my patch:
in method update() change the following line:
boolean doTemperature = _mode & DS2438_MODE_TEMPERATURE & !(_mode & DS2438_MODE_CHA);
with this one:
boolean doTemperature = _mode & DS2438_MODE_TEMPERATURE && !(_mode & DS2438_MODE_CHA);

Hope this helps!

I have added a current read fonction on your library if you are interested you can contact me and say me how can i send my mod library to you ...

 Thanks for you Library

DS2438.zip

Octopuss83