jbroadway / analog Goto Github PK

Is there a way to output logs directly (to the console, etc.)?

Hi there,

I seem to be unable to install analog on my server. I have several other libraries installed via composer (Stripe, PayPal, Google API, Medoo, etc. but can't seem to find yours.
I've included the console log:

-bash-4.2$ composer require jbroadway/analog
  [InvalidArgumentException]
  Could not find a matching version of package jbroadway/analog. Check the package spelling, your version constraint and that the package is available in a stability which matches your minimum-stability (stable).
require [--dev] [--prefer-source] [--prefer-dist] [--no-progress] [--no-suggest] [--no-update] [--no-scripts] [--update-no-dev] [--update-with-dependencies] [--update-with-all-dependencies] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [--sort-packages] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--] [<packages>]...

i run my php in virtual machine and have't composer.

If we want multiple logger instances for multiple parts of the system then we need to extend this class and copy-paste getStruct as it's based on self:: not static:: calls and getStruct is private not protected.
I.e. this way it will work with file loggers:

$subSystemOneLogger = createLogger('sys-one');
$subSystemTwoLogger = createLogger('sys-two');

$subSystemOneLogger->info('Something about subsystem one that will be logged to sys-one.debug.log and sys-one.info.log ');
...
$subSystemTwoLogger->info('Something about subsystem two that will be logged to sys-two.debug.log and sys-two.info.log ');


function createLogger($prefix = ''): AppLogger
{
    $logger = new AppLogger();
    $prefix = empty($prefix) ? '' : "$prefix.";
    $monthDir = LOG_DIR . date('Y/m');
    if (!is_dir($monthDir)) {
        mkdir($monthDir, 0775, true);
    }
    $monthDir = "$monthDir/";
    $logger->setHandler(Handler\Multi::init([
        Analog::INFO => [
            Handler\File::init(LOG_DIR . "{$prefix}debug.log"),
            Handler\File::init(LOG_DIR . "{$prefix}info.log"),
            Handler\File::init($monthDir . "{$date}_{$prefix}debug.log"),
            Handler\File::init($monthDir . "{$date}_{$prefix}info.log")
        ],
        Analog::DEBUG => [
            Handler\File::init(LOG_DIR . "{$prefix}debug.log"),
            Handler\File::init($monthDir . "{$date}_{$prefix}debug.log")
        ]
    ]));
    return $logger;
}

class AppLogger implements LoggerInterface
{
    private ?Closure $handler = null;

    public function debug($message, array $context = []): void
    {
        $this->write($this->getStruct($message, \Analog\Analog::DEBUG));
    }

    public function info($message, array $context = []): void
    {
        $this->write($this->getStruct($message, \Analog\Analog::INFO));
    }
// ... similar methods
    public function setHandler(Closure $handler): void
    {
        $this->handler = $handler;
    }

    private function write($struct): void
    {
        if (!$this->handler instanceof Closure) {
            $this->handler = \Analog\Handler\File::init(LOG_DIR . 'default.log');
        }
        call_user_func($this->handler, $struct);
    }

    private function getStruct($message, $level): array
    {
        $dt = new DateTime ('now', new DateTimeZone (\Analog\Analog::$timezone));
        return array(
            'machine' => '',
            'date' => $dt->format(\Analog\Analog::$date_format),
            'level' => $level,
            'message' => $message
        );
    }
}

My proposition is to make it less complex or add example similar to this one to achieve the same result.

According to this comment, the logging level seems to be output after being converted, but the actual output is a number. Is this a bug?

Hello,

Using Mutli or Threshold handler separately works fine; but I can't achieve to get them working together. I'm using files to log, and I'd like to get two separate files:

• one for notices, warnings, errors, etc
• another for info and debug messages (because those ones may be very verbose).

Giving the the following example:

$errors = "Errors:\n";
$debug = "Debug:\n";

\Analog\Analog::handler(
    \Analog\Handler\Multi::init(
        array (
            \Analog\Analog::NOTICE  => \Analog\Handler\Threshold::init(
                \Analog\Handler\Variable::init($errors),
                \Analog\Analog::NOTICE
            ),
            Analog::DEBUG       => \Analog\Handler\Threshold::init(
                \Analog\Handler\Variable::init($debug),
                \Analog\Analog::DEBUG
            )
        )
    )
);

\Analog\Analog::log(
    'An error',
    \Analog\Analog::ERROR
);


\Analog\Analog::log(
    'A debug message',
    \Analog\Analog::DEBUG
);

var_dump($errors);
var_dump($debug);

The output is:

string 'Errors:
' (length=8)

string 'Debug:
127.0.0.1 - 2016-11-16 21:32:13 - 3 - An error
127.0.0.1 - 2016-11-16 21:32:13 - 7 - A debug message
' (length=108)

But what I was expecting was "An error" to be written in $errors, and "A debug message" to $debug.

Did I miss something?

Thank you very much!

I execute unit tests on Analog during the construction of the package for Fedora; a build system will ran the tests, and the build will fail if unit tests are not ok.

Unit tests ran well almost all the time, I had once the following:
+ phpunit tests
PHPUnit 3.7.9 by Sebastian Bergmann.
Configuration read from /builddir/build/BUILD/analog-1.0.0-git876d8a3bb/phpunit.xml.dist
^[[41;37mF^[[0m^[[36;1mS^[[0m^[[36;1mS^[[0m
Time: 0 seconds, Memory: 3.00Mb
There was 1 failure:
1) AnalogTest::test_default
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'localhost - 2012-12-30 12:15:21 - 3 - Foo
+'localhost - 2012-12-30 12:15:20 - 3 - Foo
'

Not a big issue, but that would cause rejects from the build system, I had to disable tests (well, I actually make them quiet on error).

Maybe a solution would be to use something like:
$this->assertStringMatchesFormat ("localhost - %d-%d-%d %d:%d:%d - 3 - Foo\n", file_get_contents (Analog::handler ());

You can find a git formatted patch with this change at:
http://odysseus.x-tnd.be/fedora/php-Analog/0001-Tests-may-fail-on-seconds.patch

Hello, I'm sometimes throwing the following error:
exception 'RuntimeException' with message 'Could not lock file' in /home/travis/build/galette/galette/galette/includes/Analog-1.0.0.git876d8a3bb/Analog/Handler/File.php:27

That file should not be locked, it is used by Analog only.

I do not know how to reproduce it, I had it a very few times using my application; but that regulary fail on my travis unit tests.

Of course, I could disable file logging during tests to avoid that; but I'm afraid my users may throw the same issue on some configurations.

Any idea how to fix that?

https://github.com/ccampbell/chromephp

Hi.

On this days it's best way to send email trought authenticate SMTP )spam system, security)
It's possible add funcionality on nexts versions?

Apreciate you time.

<?php

require 'vendor/autoload.php';

use Analog\Logger;
use Analog\Handler;

$logger = new Logger();
$logger->handler(Handler\File::init('test.log'));

$logger->debug('Test', [__FILE__, __LINE__]); // context is ignored, only 'Test' is going to logs, i.e. localhost - 2023-06-01 23:40:14 - 7 - Test

Meanwhile it should work this way according to the function declaration:

	/**
	 * Detailed debug information.
	 */
	public function debug ($message, array $context = array ()) {

I'm going to include Analog in Fedora's official repositories (review request at https://bugzilla.redhat.com/show_bug.cgi?id=890417).

MIT license requires that a copy of the license text is included in the sources (see https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text); but it is currently missing.

Could you please add the LICENSE file to the sources? Thank you :)

Hi there =)

Would love it if you can tag releases, including patch updates, so that they are usable through Composer. As it stands, Analog's composer.json points to dev-master, which means it is automatically "dev" stability.

If a second library requires Analog, the end-user has to either specify 'dev' stability for all packages (not good), or specifically include Analog. Stability is not inherited (e.g. Library B which requires Analog cannot specify the stability), and so things break because everything is just thrown into dev-master.

Ultimately, this leads to composer files like this (where other/library requires Analog):

{
    "require": {
        "other/library" : "0.1.*",
        "analog/analog": "dev-master"
    }
}

When really it should just be:

{
    "require": {
        "other/library" : "0.1.*"
    }
}

phpstan says: Cannot use 'Null' as class name as it is reserved - and i guess, it´s right 😏

It appears I can send all ERRORS to one handler (Slack) and all DEBUG to Mongodb using the multi handler, but not to both simultaneously.

Ultimately, I'm looking for the ability to choose which handler is used during the log call.

In other logging libraries you can simply instantiate two versions of class, one for each destination like:

$mongo_logger = new Logger('mongo', 'db', 'info');
$slack_logger = new Logger('slack', 'api', 'info');

$mongo_logger->log('error', 'this is an error');
$slack_logger->log('error', 'this is an error');

When I try to do the same in Analog, all the log messages use the last handler set:

require 'vendor/autoload.php';
$_logger_mongo = new \Analog\Logger();
$_logger_mongo->handler(Analog\Handler\Mongo::init(
  MONGODB_HOST,
  MONGODB_LOG_DB_NAME,
  MONGODB_LOG_COLLECTION_NAME
));
$_logger_slack = new \Analog\Logger();
$_logger_slack->handler(Analog\Handler\Slackbot::init('team', 'token', 'channel'));

$_logger_slack->debug(['message' => 'Debug info for slack', 'data' => [1, 4, 6]]);
$_logger_mongo->debug(['message' => 'Debug info for mongo', 'data' => [1, 4, 6]]);

Both messages are sent to slack.

What am I doing wrong?

I'm using "dev-master" inside my composer.json

Thanks!

PHP version: 7.1.33

Example

<?php

require 'vendor/autoload.php';

use \Analog\Analog;

Analog::handler (Analog\Handler\Echo::init ());
Analog::log ('Log me');

Error

PHP Parse error:  syntax error, unexpected 'Echo' (T_ECHO), expecting identifier (T_STRING) or '{' in /path/to/your/script.php on line 7

Parse error: syntax error, unexpected 'Echo' (T_ECHO), expecting identifier (T_STRING) or '{' in /path/to/your/script.php on line 7

in Buffer.php

change function close()
to
public static function close ()

This fixes PHP strict error warning.

That is not really an issue, I made a mistake in my code, causing Analog to excess maximum execution time; using multi handler.

My stuff is wrong, not Analog one; but it was quite difficult to figure out what was happening :-)

I get something like:

Analog::log(
    'My message',
    OLD_CONSTANT
);

The "OLD_CONSTANT" value is the issue, since it no longer exists, PHP use constant name as a text value. Once in Analog/Handler/Multi.php file, we go through the while instruction that never ends because of the string instead of integer.

Maybe it would be useful to check if $info['level'] is an integer before entering the while, and either throw an exception or take a default arbitrary value.

It would be useful if you supported logging to SQL out of the box.

While Mongo is cool, MySQL is still the 'M' in LAMP for a reason.. lots more php based software systems use this as the databae

-FT

Uncaught Error: Undefined class constant 'ATTR_ERRMODE' in ..../vendor/analog/analog/lib/Analog/Handler/PDO.php:52

Because your class named PDO(as global) but your had no CONST NAMES!!!!! set \PDO const names instead PDO you forgot a slash sign, like:

class PDO {
	public static function init ($pdo, $table) {
		if (is_array ($pdo)) {
			$pdo = new \PDO ($pdo[0], $pdo[1], $pdo[2], [\PDO::ATTR_ERRMODE => \PDO::ERRMODE_EXCEPTION]);
		}

cause if i send $pdo as PDO object, it all works well, untill i send as array, and all executed as (without slash)

class PDO {
	public static function init ($pdo, $table) {
		if (is_array ($pdo)) {
			$pdo = new \PDO ($pdo[0], $pdo[1], $pdo[2], [PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION]);
		}

I'm just wondering if it is on purpose that the date is inserted into a MongoDB collection as a string instead of a date field.

We should add support for this out of the box:

https://opentelemetry.io/

Gmdate() is used to print current date.
Why don't you use date() ?
Can you add a way to configure this ?

It would be nice to have a handler to translate log levels to their names, because today they're printed as numbers in the logs.

If there is interest, I can send a pull request.